From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43613) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1KWk-0000FF-NQ for qemu-devel@nongnu.org; Sat, 25 Feb 2012 11:31:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S1KWf-0004Xt-IR for qemu-devel@nongnu.org; Sat, 25 Feb 2012 11:31:18 -0500 Received: from cantor2.suse.de ([195.135.220.15]:37889 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1KWf-0004Xl-9V for qemu-devel@nongnu.org; Sat, 25 Feb 2012 11:31:13 -0500 Message-ID: <4F490CCF.40101@suse.de> Date: Sat, 25 Feb 2012 17:31:11 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1329940095-378-1-git-send-email-sw@weilnetz.de> In-Reply-To: <1329940095-378-1-git-send-email-sw@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] w32: Support tests (make check) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Anthony Liguori , qemu-devel@nongnu.org Am 22.02.2012 20:48, schrieb Stefan Weil: > Adding $(EXESUF) is needed to make those tests work on w32 hosts, too. >=20 > v2: > Rebased, added new tests, tests sorted alphabetically. >=20 > Signed-off-by: Stefan Weil > --- > tests/Makefile | 38 +++++++++++++++++++++++--------------- > 1 files changed, 23 insertions(+), 15 deletions(-) >=20 > diff --git a/tests/Makefile b/tests/Makefile > index 74b29dc..09f2b13 100644 > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -1,16 +1,24 @@ > -CHECKS =3D check-qdict check-qfloat check-qint check-qstring check-qli= st > -CHECKS +=3D check-qjson test-qmp-output-visitor test-qmp-input-visitor > -CHECKS +=3D test-string-input-visitor test-string-output-visitor test-= coroutine > +CHECKS =3D check-qdict$(EXESUF) > +CHECKS +=3D check-qfloat$(EXESUF) > +CHECKS +=3D check-qint$(EXESUF) > +CHECKS +=3D check-qjson$(EXESUF) > +CHECKS +=3D check-qlist$(EXESUF) > +CHECKS +=3D check-qstring$(EXESUF) > +CHECKS +=3D test-coroutine$(EXESUF) > +CHECKS +=3D test-qmp-input-visitor$(EXESUF) > +CHECKS +=3D test-qmp-output-visitor$(EXESUF) > +CHECKS +=3D test-string-input-visitor$(EXESUF) > +CHECKS +=3D test-string-output-visitor$(EXESUF) Cute. (one-per-line allows to easily comment individual ones out) Some lines below were already way over 80 chars, so Reviewed-by: Andreas F=E4rber Andreas > =20 > check-qint.o check-qstring.o check-qdict.o check-qlist.o check-qfloat.= o check-qjson.o test-coroutine.o: $(GENERATED_HEADERS) > =20 > -check-qint: check-qint.o qint.o $(tools-obj-y) > -check-qstring: check-qstring.o qstring.o $(tools-obj-y) > -check-qdict: check-qdict.o qdict.o qfloat.o qint.o qstring.o qbool.o q= list.o $(tools-obj-y) > -check-qlist: check-qlist.o qlist.o qint.o $(tools-obj-y) > -check-qfloat: check-qfloat.o qfloat.o $(tools-obj-y) > -check-qjson: check-qjson.o $(qobject-obj-y) $(tools-obj-y) > -test-coroutine: test-coroutine.o qemu-timer-common.o async.o $(corouti= ne-obj-y) $(tools-obj-y) > +check-qint$(EXESUF): check-qint.o qint.o $(tools-obj-y) > +check-qstring$(EXESUF): check-qstring.o qstring.o $(tools-obj-y) > +check-qdict$(EXESUF): check-qdict.o qdict.o qfloat.o qint.o qstring.o = qbool.o qlist.o $(tools-obj-y) > +check-qlist$(EXESUF): check-qlist.o qlist.o qint.o $(tools-obj-y) > +check-qfloat$(EXESUF): check-qfloat.o qfloat.o $(tools-obj-y) > +check-qjson$(EXESUF): check-qjson.o $(qobject-obj-y) $(tools-obj-y) > +test-coroutine$(EXESUF): test-coroutine.o qemu-timer-common.o async.o = $(coroutine-obj-y) $(tools-obj-y) > =20 > test-qmp-input-visitor.o test-qmp-output-visitor.o \ > test-string-input-visitor.o test-string-output-visitor.o \ > @@ -28,19 +36,19 @@ $(SRC_PATH)/qapi-schema-test.json $(SRC_PATH)/scrip= ts/qapi-commands.py > =20 > =20 > test-string-output-visitor.o: $(addprefix $(qapi-dir)/, test-qapi-type= s.c test-qapi-types.h test-qapi-visit.c test-qapi-visit.h) $(qapi-obj-y) > -test-string-output-visitor: test-string-output-visitor.o $(qobject-obj= -y) $(qapi-obj-y) $(tools-obj-y) $(qapi-dir)/test-qapi-visit.o $(qapi-dir= )/test-qapi-types.o > +test-string-output-visitor$(EXESUF): test-string-output-visitor.o $(qo= bject-obj-y) $(qapi-obj-y) $(tools-obj-y) $(qapi-dir)/test-qapi-visit.o $= (qapi-dir)/test-qapi-types.o > =20 > test-string-input-visitor.o: $(addprefix $(qapi-dir)/, test-qapi-types= .c test-qapi-types.h test-qapi-visit.c test-qapi-visit.h) $(qapi-obj-y) > -test-string-input-visitor: test-string-input-visitor.o $(qobject-obj-y= ) $(qapi-obj-y) $(tools-obj-y) $(qapi-dir)/test-qapi-visit.o $(qapi-dir)/= test-qapi-types.o > +test-string-input-visitor$(EXESUF): test-string-input-visitor.o $(qobj= ect-obj-y) $(qapi-obj-y) $(tools-obj-y) $(qapi-dir)/test-qapi-visit.o $(q= api-dir)/test-qapi-types.o > =20 > test-qmp-output-visitor.o: $(addprefix $(qapi-dir)/, test-qapi-types.c= test-qapi-types.h test-qapi-visit.c test-qapi-visit.h) $(qapi-obj-y) > -test-qmp-output-visitor: test-qmp-output-visitor.o $(qobject-obj-y) $(= qapi-obj-y) $(tools-obj-y) $(qapi-dir)/test-qapi-visit.o $(qapi-dir)/test= -qapi-types.o > +test-qmp-output-visitor$(EXESUF): test-qmp-output-visitor.o $(qobject-= obj-y) $(qapi-obj-y) $(tools-obj-y) $(qapi-dir)/test-qapi-visit.o $(qapi-= dir)/test-qapi-types.o > =20 > test-qmp-input-visitor.o: $(addprefix $(qapi-dir)/, test-qapi-types.c = test-qapi-types.h test-qapi-visit.c test-qapi-visit.h) $(qapi-obj-y) > -test-qmp-input-visitor: test-qmp-input-visitor.o $(qobject-obj-y) $(qa= pi-obj-y) $(tools-obj-y) $(qapi-dir)/test-qapi-visit.o $(qapi-dir)/test-q= api-types.o > +test-qmp-input-visitor$(EXESUF): test-qmp-input-visitor.o $(qobject-ob= j-y) $(qapi-obj-y) $(tools-obj-y) $(qapi-dir)/test-qapi-visit.o $(qapi-di= r)/test-qapi-types.o > =20 > test-qmp-commands.o: $(addprefix $(qapi-dir)/, test-qapi-types.c test-= qapi-types.h test-qapi-visit.c test-qapi-visit.h test-qmp-marshal.c test-= qmp-commands.h) $(qapi-obj-y) > -test-qmp-commands: test-qmp-commands.o $(qobject-obj-y) $(qapi-obj-y) = $(tools-obj-y) $(qapi-dir)/test-qapi-visit.o $(qapi-dir)/test-qapi-types.= o $(qapi-dir)/test-qmp-marshal.o module.o > +test-qmp-commands$(EXESUF): test-qmp-commands.o $(qobject-obj-y) $(qap= i-obj-y) $(tools-obj-y) $(qapi-dir)/test-qapi-visit.o $(qapi-dir)/test-qa= pi-types.o $(qapi-dir)/test-qmp-marshal.o module.o > =20 > .PHONY: check > check: $(CHECKS) --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg