From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:44724)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1S1KeO-0001hK-S9
	for qemu-devel@nongnu.org; Sat, 25 Feb 2012 11:39:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1S1KeI-0005VK-9J
	for qemu-devel@nongnu.org; Sat, 25 Feb 2012 11:39:12 -0500
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:52095)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1S1KeI-0005VD-31
	for qemu-devel@nongnu.org; Sat, 25 Feb 2012 11:39:06 -0500
Message-ID: <4F490EA7.3000702@weilnetz.de>
Date: Sat, 25 Feb 2012 17:39:03 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1329940095-378-1-git-send-email-sw@weilnetz.de>
	<4F490CCF.40101@suse.de>
In-Reply-To: <4F490CCF.40101@suse.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2] w32: Support tests (make check)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

Am 25.02.2012 17:31, schrieb Andreas F=E4rber:
> Am 22.02.2012 20:48, schrieb Stefan Weil:
>> Adding $(EXESUF) is needed to make those tests work on w32 hosts, too.
>>
>> v2:
>> Rebased, added new tests, tests sorted alphabetically.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>> ---
>> tests/Makefile | 38 +++++++++++++++++++++++---------------
>> 1 files changed, 23 insertions(+), 15 deletions(-)
>>
>> diff --git a/tests/Makefile b/tests/Makefile
>> index 74b29dc..09f2b13 100644
>> --- a/tests/Makefile
>> +++ b/tests/Makefile
>> @@ -1,16 +1,24 @@
>> -CHECKS =3D check-qdict check-qfloat check-qint check-qstring check-ql=
ist
>> -CHECKS +=3D check-qjson test-qmp-output-visitor test-qmp-input-visito=
r
>> -CHECKS +=3D test-string-input-visitor test-string-output-visitor=20
>> test-coroutine
>> +CHECKS =3D check-qdict$(EXESUF)
>> +CHECKS +=3D check-qfloat$(EXESUF)
>> +CHECKS +=3D check-qint$(EXESUF)
>> +CHECKS +=3D check-qjson$(EXESUF)
>> +CHECKS +=3D check-qlist$(EXESUF)
>> +CHECKS +=3D check-qstring$(EXESUF)
>> +CHECKS +=3D test-coroutine$(EXESUF)
>> +CHECKS +=3D test-qmp-input-visitor$(EXESUF)
>> +CHECKS +=3D test-qmp-output-visitor$(EXESUF)
>> +CHECKS +=3D test-string-input-visitor$(EXESUF)
>> +CHECKS +=3D test-string-output-visitor$(EXESUF)
>
> Cute. (one-per-line allows to easily comment individual ones out)
>
> Some lines below were already way over 80 chars, so
>
> Reviewed-by: Andreas F=E4rber <afaerber@suse.de>
>
> Andreas

And as long as they remain sorted, they also reduce the risk
of merge conflicts:

When everybody just adds to the end,two different commits
will always conflict.

They won't conflictif both commits add new lines at different
locations.

Regards,
Stefan