From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35329) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1Nce-00038p-Gd for qemu-devel@nongnu.org; Sat, 25 Feb 2012 14:49:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S1NcX-0008Nk-C9 for qemu-devel@nongnu.org; Sat, 25 Feb 2012 14:49:36 -0500 Received: from mail-pz0-f45.google.com ([209.85.210.45]:33995) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1NcX-0008Ng-6E for qemu-devel@nongnu.org; Sat, 25 Feb 2012 14:49:29 -0500 Received: by dadp14 with SMTP id p14so4509246dad.4 for ; Sat, 25 Feb 2012 11:49:27 -0800 (PST) Message-ID: <4F493B43.8070304@codemonkey.ws> Date: Sat, 25 Feb 2012 13:49:23 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1329695104-15174-1-git-send-email-aliguori@us.ibm.com> <1329695104-15174-4-git-send-email-aliguori@us.ibm.com> <4F490A84.2020700@weilnetz.de> In-Reply-To: <4F490A84.2020700@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/6] gtk: add virtual console support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Anthony Liguori , qemu-devel@nongnu.org On 02/25/2012 10:21 AM, Stefan Weil wrote: > Am 20.02.2012 00:45, schrieb Anthony Liguori: >> This enables VteTerminal to be used to render the text consoles. VteTerminal is >> the same widget used by gnome-terminal which means it's VT100 emulation is as >> good as they come. >> >> It's also screen reader accessible, supports copy/paste, proper scrolling and >> most of the other features you would expect from a terminal widget. >> >> Signed-off-by: Anthony Liguori >> --- >> ui/gtk.c | 138 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> 1 files changed, 138 insertions(+), 0 deletions(-) >> >> diff --git a/ui/gtk.c b/ui/gtk.c >> index 502705b..bf65a4f 100644 >> --- a/ui/gtk.c >> +++ b/ui/gtk.c > [...] >> +static int gd_vc_handler(QemuOpts *opts, CharDriverState **chrp) >> +{ >> + CharDriverState *chr; >> + >> + chr = g_malloc0(sizeof(*chr)); > > Some time ago, there was a decision to prefer g_new / g_new0: I'm not sure where the book of decisions is kept, but I certainly don't agree. a = malloc(sizeof(*a)) is an incredibly common pattern in QEMU. It would be silly to change this pattern without good cause. Regards, Anthony Liguori > > chr = g_new0(CharDriverState, 1); > > In function gtk_display_init there is also a g_malloc0 which > should be replaced by g_new0. > > Regards, > > Stefan Weil > >