Re: [Qemu-devel] [PATCH 02/10] qtest: add support for -M pc

[Anthony Liguori <anthony@codemonkey.ws>]

On 02/25/2012 02:19 PM, Paolo Bonzini wrote:
> On 02/25/2012 08:42 PM, Anthony Liguori wrote:
>> This involves replacing the local APIC with the qtest interrupt controller.
>>
>> It should be pretty straight forward to do the same for other machine types.
>>
>> Signed-off-by: Anthony Liguori<aliguori@us.ibm.com>
>> ---
>>   hw/pc_piix.c |    3 +++
>>   1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/hw/pc_piix.c b/hw/pc_piix.c
>> index 5e11d15..2c0881e 100644
>> --- a/hw/pc_piix.c
>> +++ b/hw/pc_piix.c
>> @@ -46,6 +46,7 @@
>>   #ifdef CONFIG_XEN
>>   #  include<xen/hvm/hvm_info_table.h>
>>   #endif
>> +#include "qtest.h"
>>
>>   #define MAX_IDE_BUS 2
>>
>> @@ -212,6 +213,8 @@ static void pc_init1(MemoryRegion *system_memory,
>>           i8259 = kvm_i8259_init(isa_bus);
>>       } else if (xen_enabled()) {
>>           i8259 = xen_interrupt_controller_init();
>> +    } else if (qtest_enabled()) {
>> +        i8259 = qtest_interrupt_controller_init();
>>       } else {
>>           cpu_irq = pc_allocate_cpu_irq();
>>           i8259 = i8259_init(isa_bus, cpu_irq[0]);
>
> This is not needed anymore.

Why?  This is necessary for IRQ to work.

You mean, if you use irq_intercept, this isn't needed?

Regards,

Anthony Liguori

>
> Paolo
>
>