From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:37246)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S1OvG-0000lx-Bu
	for qemu-devel@nongnu.org; Sat, 25 Feb 2012 16:13:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S1Ov8-00028Q-Pk
	for qemu-devel@nongnu.org; Sat, 25 Feb 2012 16:12:54 -0500
Received: from mail-pw0-f45.google.com ([209.85.160.45]:35604)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S1Ov8-00028K-JX
	for qemu-devel@nongnu.org; Sat, 25 Feb 2012 16:12:46 -0500
Received: by pbbro12 with SMTP id ro12so4737780pbb.4
	for <qemu-devel@nongnu.org>; Sat, 25 Feb 2012 13:12:45 -0800 (PST)
Message-ID: <4F494EC7.6070905@codemonkey.ws>
Date: Sat, 25 Feb 2012 15:12:39 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1330198969-27364-1-git-send-email-aliguori@us.ibm.com>	<1330198969-27364-3-git-send-email-aliguori@us.ibm.com>
	<jibfnp$s95$1@dough.gmane.org>
In-Reply-To: <jibfnp$s95$1@dough.gmane.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 02/10] qtest: add support for -M pc
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

On 02/25/2012 02:19 PM, Paolo Bonzini wrote:
> On 02/25/2012 08:42 PM, Anthony Liguori wrote:
>> This involves replacing the local APIC with the qtest interrupt controller.
>>
>> It should be pretty straight forward to do the same for other machine types.
>>
>> Signed-off-by: Anthony Liguori<aliguori@us.ibm.com>
>> ---
>>   hw/pc_piix.c |    3 +++
>>   1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/hw/pc_piix.c b/hw/pc_piix.c
>> index 5e11d15..2c0881e 100644
>> --- a/hw/pc_piix.c
>> +++ b/hw/pc_piix.c
>> @@ -46,6 +46,7 @@
>>   #ifdef CONFIG_XEN
>>   #  include<xen/hvm/hvm_info_table.h>
>>   #endif
>> +#include "qtest.h"
>>
>>   #define MAX_IDE_BUS 2
>>
>> @@ -212,6 +213,8 @@ static void pc_init1(MemoryRegion *system_memory,
>>           i8259 = kvm_i8259_init(isa_bus);
>>       } else if (xen_enabled()) {
>>           i8259 = xen_interrupt_controller_init();
>> +    } else if (qtest_enabled()) {
>> +        i8259 = qtest_interrupt_controller_init();
>>       } else {
>>           cpu_irq = pc_allocate_cpu_irq();
>>           i8259 = i8259_init(isa_bus, cpu_irq[0]);
>
> This is not needed anymore.

Why?  This is necessary for IRQ to work.

You mean, if you use irq_intercept, this isn't needed?

Regards,

Anthony Liguori

>
> Paolo
>
>