From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52973) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1PBZ-0005lk-9Z for qemu-devel@nongnu.org; Sat, 25 Feb 2012 16:29:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S1PBR-0004Mq-JG for qemu-devel@nongnu.org; Sat, 25 Feb 2012 16:29:44 -0500 Received: from mail-pw0-f45.google.com ([209.85.160.45]:53784) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1PBR-0004Mg-Cy for qemu-devel@nongnu.org; Sat, 25 Feb 2012 16:29:37 -0500 Received: by pbbro12 with SMTP id ro12so4748199pbb.4 for ; Sat, 25 Feb 2012 13:29:36 -0800 (PST) Message-ID: <4F4952B7.9040705@codemonkey.ws> Date: Sat, 25 Feb 2012 15:29:27 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1330198969-27364-1-git-send-email-aliguori@us.ibm.com> <1330198969-27364-3-git-send-email-aliguori@us.ibm.com> <4F494EC7.6070905@codemonkey.ws> <4F4950BC.2060102@suse.de> In-Reply-To: <4F4950BC.2060102@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 02/10] qtest: add support for -M pc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: Paolo Bonzini , qemu-devel@nongnu.org On 02/25/2012 03:21 PM, Andreas Färber wrote: > Am 25.02.2012 22:12, schrieb Anthony Liguori: >> On 02/25/2012 02:19 PM, Paolo Bonzini wrote: >>> On 02/25/2012 08:42 PM, Anthony Liguori wrote: >>>> This involves replacing the local APIC with the qtest interrupt >>>> controller. >>>> >>>> It should be pretty straight forward to do the same for other machine >>>> types. >>>> >>>> Signed-off-by: Anthony Liguori >>>> --- >>>> hw/pc_piix.c | 3 +++ >>>> 1 files changed, 3 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/hw/pc_piix.c b/hw/pc_piix.c >>>> index 5e11d15..2c0881e 100644 >>>> --- a/hw/pc_piix.c >>>> +++ b/hw/pc_piix.c >>>> @@ -46,6 +46,7 @@ >>>> #ifdef CONFIG_XEN >>>> # include >>>> #endif >>>> +#include "qtest.h" >>>> >>>> #define MAX_IDE_BUS 2 >>>> >>>> @@ -212,6 +213,8 @@ static void pc_init1(MemoryRegion *system_memory, >>>> i8259 = kvm_i8259_init(isa_bus); >>>> } else if (xen_enabled()) { >>>> i8259 = xen_interrupt_controller_init(); >>>> + } else if (qtest_enabled()) { >>>> + i8259 = qtest_interrupt_controller_init(); >>>> } else { >>>> cpu_irq = pc_allocate_cpu_irq(); >>>> i8259 = i8259_init(isa_bus, cpu_irq[0]); >>> >>> This is not needed anymore. >> >> Why? This is necessary for IRQ to work. >> >> You mean, if you use irq_intercept, this isn't needed? > > The reason for Paolo's RFC was to _avoid_ having to touch every target > with code such as the above, no? I misunderstood. I thought irq_intercept was intercepting the RTC IRQ. I now see it's intercepting the I/O APIC irqs. Regards, Anthony Liguori > > Andreas >