From: "Andreas Färber" <afaerber@suse.de>
To: Stefan Weil <sw@weilnetz.de>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Spelling fixes in comments (it's -> its)
Date: Sun, 26 Feb 2012 18:18:57 +0100 [thread overview]
Message-ID: <4F4A6981.2030008@suse.de> (raw)
In-Reply-To: <1330263343-21307-1-git-send-email-sw@weilnetz.de>
Am 26.02.2012 14:35, schrieb Stefan Weil:
> * it's -> its (fixed for all files)
> * dont -> don't (only fixed in a line which was touched by the previous fix)
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Andreas Färber <afaerber@suse.de>
Except for one omission:
> ---
> configure | 2 +-
> hw/exynos4210_mct.c | 2 +-
> hw/usb-ccid.c | 2 +-
> include/qemu/object.h | 4 ++--
> kvm-all.c | 2 +-
> libcacard/vscclient.c | 2 +-
> linux-user/signal.c | 2 +-
> qemu-file.h | 2 +-
> target-mips/op_helper.c | 2 +-
> 9 files changed, 10 insertions(+), 10 deletions(-)
> diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c
> index c51b9cb..7d6773d 100644
> --- a/target-mips/op_helper.c
> +++ b/target-mips/op_helper.c
> @@ -1930,7 +1930,7 @@ target_ulong helper_evpe(void)
>
> do {
> if (other_cpu != env
> - /* If the VPE is WFI, dont distrub it's sleep. */
> + /* If the VPE is WFI, don't distrub its sleep. */
While at it, please also fix "disturb". :)
Also I've generally wondered if there is a reason for having two spaces
before */? Some do, some don't.
Andreas
> && !mips_vpe_is_wfi(other_cpu)) {
> /* Enable the VPE. */
> other_cpu->mvp->CP0_MVPControl |= (1 << CP0MVPCo_EVP);
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-02-26 17:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-26 13:35 [Qemu-devel] [PATCH] Spelling fixes in comments (it's -> its) Stefan Weil
2012-02-26 17:18 ` Andreas Färber [this message]
2012-02-26 17:46 ` [Qemu-devel] [PATCH v2] " Stefan Weil
2012-03-05 16:42 ` [Qemu-devel] [PATCH] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4A6981.2030008@suse.de \
--to=afaerber@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).