From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46724)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1S1wsf-00035L-1p
	for qemu-devel@nongnu.org; Mon, 27 Feb 2012 04:28:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1S1wsY-0004Zw-Ra
	for qemu-devel@nongnu.org; Mon, 27 Feb 2012 04:28:28 -0500
Received: from mx1.redhat.com ([209.132.183.28]:49719)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1S1wsY-0004YX-K8
	for qemu-devel@nongnu.org; Mon, 27 Feb 2012 04:28:22 -0500
Message-ID: <4F4B4D5E.4070609@redhat.com>
Date: Mon, 27 Feb 2012 10:31:10 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1330268124-10725-1-git-send-email-stefanha@linux.vnet.ibm.com>
	<CAEH94LiRXAXN6_cqaKN1sFafMHbsSg3u6HR9TUz+VJqS3XEtzg@mail.gmail.com>
	<4F4B41E1.3080006@redhat.com>
In-Reply-To: <4F4B41E1.3080006@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qed: replace vm_clock with rt_clock for
	qemu-tool compatibility
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Zhi Yong Wu <zwu.kernel@gmail.com>, Zhi Yong Wu <wuzhy@cn.ibm.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, qemu-devel@nongnu.org

Am 27.02.2012 09:42, schrieb Paolo Bonzini:
> On 02/27/2012 08:35 AM, Zhi Yong Wu wrote:
>> Since vm_clock is created via qemu_init_main_loop(), when QED read
>> vm_clock, why will this call abort()?
>> Can you elaborate this? what is its call path?
>>
> 
> It will crash in cpu_get_clock() (in qemu-tool.c).

The fix isn't very nice if it makes migration impossible. I'd like to
introduce a similar timer in qcow2 which does support migration and
breaking it is not an option. So what about (completely untested)...

diff --git a/qemu-tool.c b/qemu-tool.c
index 183a583..edb84f5 100644
--- a/qemu-tool.c
+++ b/qemu-tool.c
@@ -61,7 +61,7 @@ void monitor_protocol_event(MonitorEvent event,
QObject *data)

 int64_t cpu_get_clock(void)
 {
-    abort();
+    return 0;
 }

 int64_t cpu_get_icount(void)

Kevin