From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S201B-0001Nk-Lz for qemu-devel@nongnu.org; Mon, 27 Feb 2012 07:49:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S2017-0005Sm-JO for qemu-devel@nongnu.org; Mon, 27 Feb 2012 07:49:29 -0500 Received: from mail-pw0-f45.google.com ([209.85.160.45]:63172) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2017-0005Sf-CC for qemu-devel@nongnu.org; Mon, 27 Feb 2012 07:49:25 -0500 Received: by pbbro12 with SMTP id ro12so6404655pbb.4 for ; Mon, 27 Feb 2012 04:49:24 -0800 (PST) Sender: Paolo Bonzini Message-ID: <4F4B7BCD.6000808@redhat.com> Date: Mon, 27 Feb 2012 13:49:17 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20120224170143.78f55d3e@doriath.home> <8eaeb022-ea20-4823-886a-e629bce1c776@zmail16.collab.prod.int.phx2.redhat.com> <20120227091215.7849e558@doriath.home> In-Reply-To: <20120227091215.7849e558@doriath.home> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: kwolf@redhat.com, Federico Simoncelli , mtosatti@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com On 02/27/2012 01:12 PM, Luiz Capitulino wrote: > > If I didn't make any mistake in the code I'm just enforcing that when > > you specify "incremental" you also need a new image. > > There are still other valid cases where they are optional. > > Which operation will be performed if 'incremental' is not passed? If > it's passed, which operation will be performed if 'new_image_file' is not? There are four cases: 1) incremental=false, new_image_file not passed: right now fail; in the future: - create an image on dest with no backing file; - writes will be mirrored to current_image_file and dest - start streaming from current_image_file to dest 2) incremental=false, new_image_file passed: right now fail; in the future: - create an image on dest with no backing file; - live-snapshot based on current_image_file to new_image_file; - writes will be mirrored to new_image_file and dest - start streaming from current_image_file to dest 3) incremental=true, new_image_file not passed: - error 4) incremental=true, new_image_file passed: - no images will be created - writes will be mirrored to new_image_file and dest Paolo