From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50683) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S20vl-0005jr-8K for qemu-devel@nongnu.org; Mon, 27 Feb 2012 08:48:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S20vf-0007G1-7h for qemu-devel@nongnu.org; Mon, 27 Feb 2012 08:47:57 -0500 Received: from cantor2.suse.de ([195.135.220.15]:43898 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S20vf-0007Fx-1h for qemu-devel@nongnu.org; Mon, 27 Feb 2012 08:47:51 -0500 Message-ID: <4F4B8985.2080308@suse.de> Date: Mon, 27 Feb 2012 14:47:49 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1329817003-31125-1-git-send-email-hare@suse.de> <20120223153419.GA20732@redhat.com> In-Reply-To: <20120223153419.GA20732@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH][v14] megasas: LSI Megaraid SAS HBA emulation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Gerhard Wiesinger , qemu-devel@nongnu.org, Hannes Reinecke , Alexander Graf Am 23.02.2012 16:34, schrieb Michael S. Tsirkin: > On Tue, Feb 21, 2012 at 10:36:43AM +0100, Hannes Reinecke wrote: >> diff --git a/hw/megasas.c b/hw/megasas.c >> new file mode 100644 >> index 0000000..083c3d3 >> --- /dev/null >> +++ b/hw/megasas.c >> +static void megaraid1078_register_types(void) >> +{ >> + type_register_static(&megasas_info); >> +} >> + >> +type_init(megaraid1078_register_types); >=20 >=20 > why not megasas_ ? And while at it, no semicolon after type_init() please. It defines a function and I recently cleaned up all callers. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg