From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42711) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S23nW-0002ud-Qq for qemu-devel@nongnu.org; Mon, 27 Feb 2012 11:51:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S23nR-0005mG-1i for qemu-devel@nongnu.org; Mon, 27 Feb 2012 11:51:38 -0500 Received: from mail-pz0-f45.google.com ([209.85.210.45]:36716) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S23nQ-0005lz-RE for qemu-devel@nongnu.org; Mon, 27 Feb 2012 11:51:32 -0500 Received: by dadp14 with SMTP id p14so6487634dad.4 for ; Mon, 27 Feb 2012 08:51:31 -0800 (PST) Sender: Paolo Bonzini Message-ID: <4F4BB487.6080001@redhat.com> Date: Mon, 27 Feb 2012 17:51:19 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <4F4BA56B.7040608@redhat.com> In-Reply-To: <4F4BA56B.7040608@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/2] qapi: Introduce blockdev-group-snapshot-sync command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Jeff Cody , lcapitulino@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com On 02/27/2012 04:46 PM, Kevin Wolf wrote: > > + /* > > + * Now we will drain, flush, & pivot everything - we are committed at this > > + * point. > > + */ > > + bdrv_drain_all(); > > I would feel more comfortable if we could do the bdrv_drain_all() at the > very beginning of the function. Not that I know of a specific scenario > that would go wrong, but you have a nested main loop here that could do > more or less anything. The same could be said of a bdrv_read or a bdrv_write done by bdrv_open, no? Paolo