From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:37890)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1S2IRS-0001rI-DU
	for qemu-devel@nongnu.org; Tue, 28 Feb 2012 03:29:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1S2IRN-0000J3-Ey
	for qemu-devel@nongnu.org; Tue, 28 Feb 2012 03:29:49 -0500
Received: from mx1.redhat.com ([209.132.183.28]:29733)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1S2IRN-0000Im-6o
	for qemu-devel@nongnu.org; Tue, 28 Feb 2012 03:29:45 -0500
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1S8TgUL032207
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 28 Feb 2012 03:29:43 -0500
Received: from rincewind.home.kraxel.org (ovpn-116-50.ams2.redhat.com
	[10.36.116.50])
	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP
	id q1S8Td73029288
	for <qemu-devel@nongnu.org>; Tue, 28 Feb 2012 03:29:41 -0500
Message-ID: <4F4C9072.8040903@redhat.com>
Date: Tue, 28 Feb 2012 09:29:38 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1330337410-21905-1-git-send-email-kraxel@redhat.com>
	<20120227191337.GM7395@garlic.redhat.com>
In-Reply-To: <20120227191337.GM7395@garlic.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qxl: properly handle upright and
 non-shared surfaces
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

>> -    dprint(qxl, 1, "%s: stride %d, [%d, %d, %d, %d]\n", __func__,
>> +    dprint(qxl, 2, "%s: stride %d, [%d, %d, %d, %d]\n", __func__,
> 
> You know 2 is used right now for high frequency stuff, like
> interface_get_command? I think this should be lower. Anyway, not a big
> deal.

/me used '1' for important but infrequent stuff, basically all init ops,
mode switching etc.  This can happen quite alot in case you are running
with SDL.  Maybe we need not just 1+2 but 1+2+3 levels, with 3 for the
really frequent stuff which will flood the logfiles.

Or even better just turn them all into tracepoints ...

cheers,
  Gerd