From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44615) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2Nq9-0001Tn-Ii for qemu-devel@nongnu.org; Tue, 28 Feb 2012 09:15:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S2Npw-00025n-Jl for qemu-devel@nongnu.org; Tue, 28 Feb 2012 09:15:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:19119) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2Npw-00025U-BZ for qemu-devel@nongnu.org; Tue, 28 Feb 2012 09:15:28 -0500 Message-ID: <4F4CE250.9030701@redhat.com> Date: Tue, 28 Feb 2012 15:18:56 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1330299995-8688-1-git-send-email-aliguori@us.ibm.com> <1330299995-8688-7-git-send-email-aliguori@us.ibm.com> <4F4BE334.7050504@weilnetz.de> In-Reply-To: <4F4BE334.7050504@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 6/8] gtk: add support for screen scaling and full screen (v2) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Paolo Bonzini , Anthony Liguori , qemu-devel@nongnu.org Am 27.02.2012 21:10, schrieb Stefan Weil: > Am 27.02.2012 00:46, schrieb Anthony Liguori: >> Basic menu items to enter full screen mode and zoom in/out. Unlike SDL, we >> don't allow arbitrary scaling based on window resizing. The current >> behavior >> with SDL causes a lot of problems for me. >> >> Sometimes I accidentally resize the window a tiny bit while trying to >> move it >> (Ubuntu's 1-pixel window decorations don't help here). After that, >> scaling is >> now active and if the screen changes size again, badness ensues since the >> aspect ratio is skewed. >> >> Allowing zooming by 25% in and out should cover most use cases. We can >> add a >> more flexible scaling later but for now, I think this is a more friendly >> behavior. >> >> Signed-off-by: Anthony Liguori >> --- >> v1 -> v2 >> - fix scaling (Paolo) >> - use ctrl-alt-+ instead of ctrl-alt-= for zoom >> --- >> ui/gtk.c | 92 >> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--- >> 1 files changed, 88 insertions(+), 4 deletions(-) >> >> diff --git a/ui/gtk.c b/ui/gtk.c >> index 0dac807..578cb94 100644 >> --- a/ui/gtk.c >> +++ b/ui/gtk.c > > [...] > >> >> + s->full_screen_item = gtk_check_menu_item_new_with_mnemonic("_Full >> Screen"); > > I suggest using the GTK standard widget GTK_STOCK_FULLSCREEN here. > That's not a check menu item, so some more changes will be needed. > > Full screen mode does not need a check menu item, because you only > see the menu item when it is not in full screen mode. Tried Alt-V in full screen mode? ;-) (Yes, I'd consider it a bug) Kevin