From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48616)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1S2hyt-0001uU-1L
	for qemu-devel@nongnu.org; Wed, 29 Feb 2012 06:46:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1S2hym-0002Nt-On
	for qemu-devel@nongnu.org; Wed, 29 Feb 2012 06:46:02 -0500
Received: from mx1.redhat.com ([209.132.183.28]:33202)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1S2hym-0002Nj-HU
	for qemu-devel@nongnu.org; Wed, 29 Feb 2012 06:45:56 -0500
Message-ID: <4F4E0FED.8040301@redhat.com>
Date: Wed, 29 Feb 2012 13:45:49 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <20120228175914.GA28479@redhat.com>
	<4F4D1951.4040807@codemonkey.ws> <4F4D19C5.8030507@redhat.com>
	<4F4D2789.2070306@codemonkey.ws> <4F4D2848.30007@redhat.com>
	<4F4D290F.90907@codemonkey.ws>
	<20120228225805.GA8740@redhat.com> <4F4DF94A.80803@redhat.com>
	<20120229102306.GA4924@redhat.com> <4F4E03BE.0@redhat.com>
	<20120229112552.GB5233@redhat.com> <4F4E0C8A.9040902@redhat.com>
In-Reply-To: <4F4E0C8A.9040902@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL] Memory core space reduction
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, Anthony Liguori <anthony@codemonkey.ws>

On 02/29/2012 01:31 PM, Avi Kivity wrote:
> On 02/29/2012 01:25 PM, Michael S. Tsirkin wrote:
> > It does not crash under valgrind :)
> > But valgrid did show some info:
> >
> > ==9202== Invalid write of size 8
> > ==9202==    at 0x2F313D: portio_list_add_1 (ioport.c:379)
> >
>
> Anthony, your "bad bisect" was in fact good - it was the very first
> patch that was bad:
>
>     piolist->regions[piolist->nr++] = region;
>     piolist->aliases[piolist->nr++] = alias;
>
> will fix.
>

Please retry with the new memory/core branch I just pushed.  If using
kvm, also apply the patch I posted elsewhere in this thread.

-- 
error compiling committee.c: too many arguments to function