From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34057)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mprivozn@redhat.com>) id 1S2jPv-00054R-8k
	for qemu-devel@nongnu.org; Wed, 29 Feb 2012 08:18:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mprivozn@redhat.com>) id 1S2jPq-0004jh-GO
	for qemu-devel@nongnu.org; Wed, 29 Feb 2012 08:18:02 -0500
Received: from mx1.redhat.com ([209.132.183.28]:12736)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mprivozn@redhat.com>) id 1S2jPq-0004jT-8Z
	for qemu-devel@nongnu.org; Wed, 29 Feb 2012 08:17:58 -0500
Message-ID: <4F4E2580.70706@redhat.com>
Date: Wed, 29 Feb 2012 14:17:52 +0100
From: Michal Privoznik <mprivozn@redhat.com>
MIME-Version: 1.0
References: <2c332c139b3d6b38e2ef93e2efc951f8565c4a52.1329649806.git.mprivozn@redhat.com>
	<20120223122034.728c259c@doriath.home>
	<4F4BD034.5030400@redhat.com> <20120228020728.GB2725@illuin>
	<20120228112222.31482e44@doriath.home>
	<20120228170938.GC2725@illuin>
	<20120228144142.71dd6641@doriath.home>
In-Reply-To: <20120228144142.71dd6641@doriath.home>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-devel@nongnu.org

On 28.02.2012 18:41, Luiz Capitulino wrote:
>> Hmm, I know Michal already sent a new version with my suggestions, but
>> > you're right, splitting out the commands simplified both the responses,
>> > and makes it easier to discover whether or not that information is
>> > available, since you can look for the command in guest-info before
>> > attempting it, rather than attempting it and then looking at the result.
>> > 
>> > So maybe just something this?:
>> > 
>> > { 'type': 'GuestNetworkInterface',
>> >   'data': { 'name': 'str',
>> >             '*hardware-address': 'str',
>> >             '*ip-addresses': ['GuestIpAddress'] } } }
>> > 
>> > { 'command': 'guest-network-interfaces',
>> >   'returns': ['GuestNetworkInterface'] }
> Looks good to me, the only nitpick is that I think command names should be
> verbs.

guest-get-network-interfaces?