From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 0/3] qemu-iotests: add image streaming tests
Date: Wed, 29 Feb 2012 14:35:41 +0100 [thread overview]
Message-ID: <4F4E29AD.1010600@redhat.com> (raw)
In-Reply-To: <1330521922-32540-1-git-send-email-stefanha@linux.vnet.ibm.com>
Am 29.02.2012 14:25, schrieb Stefan Hajnoczi:
> This series adds the image streaming test suite to qemu-iotests. It covers the
> 'block_stream', 'block_job_cancel', 'block_job_set_speed', and
> 'query-block-jobs' QMP interfaces.
>
> Since these tests involve QMP it is no longer convenient to write them in bash.
> Instead these tests are written in Python and make use of the existing
> QMP/qmp.py module. In order to achieve this, it adds an iotests Python module
> that handles interaction with the qemu-iotests framework.
>
> If you want to review using a top-down approach, I suggest reading this series
> backwards, starting from Patch 3 which introduces 030, the image streaming test
> suite.
>
> Or if you like the bottom-up approach:
>
> * Patch 1 exports TEST_DIR from qemu-iotests so test executables can learn the
> temporary directory path.
>
> * Patch 2 adds the iotests.py module, which brings together qemu-iotests,
> unittest, and QEMU in a way that is easy to consume in Python.
>
> * Patch 3 adds 030, the image streaming test suite.
>
> Tests pass successfully with both qcow2 and qed on qemu.git/master.
>
> v2:
> * Python 2.6 compatibility, use public unittest.TextTestRunner [Kevin]
>
> Stefan Hajnoczi (3):
> qemu-iotests: export TEST_DIR for non-bash tests
> qemu-iotests: add iotests Python module
> test: add image streaming tests
>
> tests/qemu-iotests/030 | 151 +++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/030.out | 5 +
> tests/qemu-iotests/common.config | 2 +
> tests/qemu-iotests/group | 1 +
> tests/qemu-iotests/iotests.py | 164 ++++++++++++++++++++++++++++++++++++++
> 5 files changed, 323 insertions(+), 0 deletions(-)
> create mode 100755 tests/qemu-iotests/030
> create mode 100644 tests/qemu-iotests/030.out
> create mode 100644 tests/qemu-iotests/iotests.py
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2012-02-29 13:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 13:25 [Qemu-devel] [PATCH v2 0/3] qemu-iotests: add image streaming tests Stefan Hajnoczi
2012-02-29 13:25 ` [Qemu-devel] [PATCH v2 1/3] qemu-iotests: export TEST_DIR for non-bash tests Stefan Hajnoczi
2012-02-29 13:25 ` [Qemu-devel] [PATCH v2 2/3] qemu-iotests: add iotests Python module Stefan Hajnoczi
2012-02-29 13:25 ` [Qemu-devel] [PATCH v2 3/3] test: add image streaming tests Stefan Hajnoczi
2012-02-29 13:35 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4E29AD.1010600@redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).