From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56855)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1S2je3-0002h6-UC
	for qemu-devel@nongnu.org; Wed, 29 Feb 2012 08:32:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1S2jdf-0007Yh-CI
	for qemu-devel@nongnu.org; Wed, 29 Feb 2012 08:32:39 -0500
Received: from mx1.redhat.com ([209.132.183.28]:17653)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1S2jdf-0007YF-3Z
	for qemu-devel@nongnu.org; Wed, 29 Feb 2012 08:32:15 -0500
Message-ID: <4F4E29AD.1010600@redhat.com>
Date: Wed, 29 Feb 2012 14:35:41 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1330521922-32540-1-git-send-email-stefanha@linux.vnet.ibm.com>
In-Reply-To: <1330521922-32540-1-git-send-email-stefanha@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 0/3] qemu-iotests: add image streaming
	tests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org

Am 29.02.2012 14:25, schrieb Stefan Hajnoczi:
> This series adds the image streaming test suite to qemu-iotests.  It covers the
> 'block_stream', 'block_job_cancel', 'block_job_set_speed', and
> 'query-block-jobs' QMP interfaces.
> 
> Since these tests involve QMP it is no longer convenient to write them in bash.
> Instead these tests are written in Python and make use of the existing
> QMP/qmp.py module.  In order to achieve this, it adds an iotests Python module
> that handles interaction with the qemu-iotests framework.
> 
> If you want to review using a top-down approach, I suggest reading this series
> backwards, starting from Patch 3 which introduces 030, the image streaming test
> suite.
> 
> Or if you like the bottom-up approach:
> 
> * Patch 1 exports TEST_DIR from qemu-iotests so test executables can learn the
>   temporary directory path.
> 
> * Patch 2 adds the iotests.py module, which brings together qemu-iotests,
>   unittest, and QEMU in a way that is easy to consume in Python.
> 
> * Patch 3 adds 030, the image streaming test suite.
> 
> Tests pass successfully with both qcow2 and qed on qemu.git/master.
> 
> v2:
>  * Python 2.6 compatibility, use public unittest.TextTestRunner [Kevin]
> 
> Stefan Hajnoczi (3):
>   qemu-iotests: export TEST_DIR for non-bash tests
>   qemu-iotests: add iotests Python module
>   test: add image streaming tests
> 
>  tests/qemu-iotests/030           |  151 +++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/030.out       |    5 +
>  tests/qemu-iotests/common.config |    2 +
>  tests/qemu-iotests/group         |    1 +
>  tests/qemu-iotests/iotests.py    |  164 ++++++++++++++++++++++++++++++++++++++
>  5 files changed, 323 insertions(+), 0 deletions(-)
>  create mode 100755 tests/qemu-iotests/030
>  create mode 100644 tests/qemu-iotests/030.out
>  create mode 100644 tests/qemu-iotests/iotests.py

Thanks, applied to the block branch.

Kevin