From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:32842)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1S2kTR-0001oo-Ta
	for qemu-devel@nongnu.org; Wed, 29 Feb 2012 09:25:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1S2kTL-0001S5-5P
	for qemu-devel@nongnu.org; Wed, 29 Feb 2012 09:25:45 -0500
Received: from mail-pw0-f45.google.com ([209.85.160.45]:50073)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1S2kTK-0001Rf-TD
	for qemu-devel@nongnu.org; Wed, 29 Feb 2012 09:25:39 -0500
Received: by pbcuo1 with SMTP id uo1so1833408pbc.4
	for <qemu-devel@nongnu.org>; Wed, 29 Feb 2012 06:25:36 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4F4E3559.3010801@redhat.com>
Date: Wed, 29 Feb 2012 15:25:29 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1330522650-15357-1-git-send-email-pbonzini@redhat.com>
	<1330522650-15357-4-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1330522650-15357-4-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/6] rename blockdev-group-snapshot-sync
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel <qemu-devel@nongnu.org>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, Jeff Cody <jcody@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>, Federico Simoncelli <fsimonce@redhat.com>, Eric Blake <eblake@redhat.com>

Il 29/02/2012 14:37, Paolo Bonzini ha scritto:
> +            assert(!(dev_info->snapshot->has_format && format));

Oops, this wanted to be

assert(dev_info->snapshot->has_format == (format != NULL));

but it can just be omitted, I wasn't sure of how QAPI handled optionals.

Paolo