qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] slirp memory leaks (from valgrind)
Date: Wed, 29 Feb 2012 17:32:13 +0100	[thread overview]
Message-ID: <4F4E530D.2070703@siemens.com> (raw)
In-Reply-To: <20120229161521.GA8661@redhat.com>

On 2012-02-29 17:15, Michael S. Tsirkin wrote:
> valgrind run shows a memory leak in slirp:
> 
> ==21745== 360 (168 direct, 192 indirect) bytes in 1 blocks are definitely lost in loss record 700 of 856
> ==21745==    at 0x4A05FDE: malloc (vg_replace_malloc.c:236)
> ==21745==    by 0x298F01: socreate (socket.c:48)
> ==21745==    by 0x298FBC: tcp_listen (socket.c:601)
> ==21745==    by 0x296325: slirp_add_hostfwd (slirp.c:794)
> ==21745==    by 0x25E7BB: slirp_hostfwd (slirp.c:413)
> ==21745==    by 0x25F7C6: net_init_slirp (slirp.c:254)
> ==21745==    by 0x25BC72: net_client_init (net.c:1155)
> ==21745==    by 0x27C759: qemu_opts_foreach (qemu-option.c:1053)
> ==21745==    by 0x25AED1: net_init_clients (net.c:1452)
> ==21745==    by 0x24EC5A: main (vl.c:3277)
> 
> comments?

The socket tcp_listen creates and returns is not handled by
slirp_add_hostfwd, but it is part of the tcb queue of the slirp
instance. Hmm, maybe we fail to clean up the tcb on slirp destruction,
and that is the issue...

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

      reply	other threads:[~2012-02-29 16:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-29 16:15 [Qemu-devel] slirp memory leaks (from valgrind) Michael S. Tsirkin
2012-02-29 16:32 ` Jan Kiszka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F4E530D.2070703@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).