qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel <xen-devel@lists.xensource.com>,
	QEMU-devel <qemu-devel@nongnu.org>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: Re: [Qemu-devel] [PATCH] MSI / MSIX injection for Xen HVM
Date: Wed, 29 Feb 2012 18:47:33 +0100	[thread overview]
Message-ID: <4F4E64B5.5080900@siemens.com> (raw)
In-Reply-To: <1330536077.10387.57.camel@leeds.uk.xensource.com>

On 2012-02-29 18:21, Wei Liu wrote:
> Hi all
> 
> This patch adds MSI / MSIX injection for Xen HVM guest. This is not new,
> six months ago we had a discussion in
> http://marc.info/?l=qemu-devel&m=130639451725966&w=2

There are some coding style issues, please use checkpatch.pl.

Back then I voted against "if (xen_enabled())" as I was planning for a
msi injection hook that also Xen could use. That may change again, the
final MSI layer design is not settled yet. Therefore, no concerns from
that POV, this work takes longer. We can refactor the Xen hooks during
that run again.

However, you know that you miss those (uncommon) messages that are
injected via DMA? They end up directly in apic_deliver_msi (where KVM
will once pick them up as well).

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

  reply	other threads:[~2012-02-29 17:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-29 17:21 [Qemu-devel] [PATCH] MSI / MSIX injection for Xen HVM Wei Liu
2012-02-29 17:47 ` Jan Kiszka [this message]
2012-03-01 10:20   ` Wei Liu
2012-03-01 11:22     ` Jan Kiszka
2012-03-01 11:51       ` Wei Liu
2012-03-01 12:56         ` Paolo Bonzini
2012-03-01 14:06           ` Stefano Stabellini
2012-03-01 14:03             ` Paolo Bonzini
2012-03-01 14:50               ` Stefano Stabellini
2012-03-01 15:56                 ` Paolo Bonzini
2012-03-01 16:06                   ` Stefano Stabellini
2012-04-03 16:44                   ` Wei Liu
2012-04-03 16:52                     ` Jan Kiszka
2012-04-04 13:40                     ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F4E64B5.5080900@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=Stefano.Stabellini@eu.citrix.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).