From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45099) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2nd5-0002Y0-MP for qemu-devel@nongnu.org; Wed, 29 Feb 2012 12:48:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S2nd0-0003gs-Cs for qemu-devel@nongnu.org; Wed, 29 Feb 2012 12:47:55 -0500 Received: from goliath.siemens.de ([192.35.17.28]:15141) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2ncz-0003gG-Tf for qemu-devel@nongnu.org; Wed, 29 Feb 2012 12:47:50 -0500 Message-ID: <4F4E64B5.5080900@siemens.com> Date: Wed, 29 Feb 2012 18:47:33 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1330536077.10387.57.camel@leeds.uk.xensource.com> In-Reply-To: <1330536077.10387.57.camel@leeds.uk.xensource.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] MSI / MSIX injection for Xen HVM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wei Liu Cc: xen-devel , QEMU-devel , Stefano Stabellini On 2012-02-29 18:21, Wei Liu wrote: > Hi all > > This patch adds MSI / MSIX injection for Xen HVM guest. This is not new, > six months ago we had a discussion in > http://marc.info/?l=qemu-devel&m=130639451725966&w=2 There are some coding style issues, please use checkpatch.pl. Back then I voted against "if (xen_enabled())" as I was planning for a msi injection hook that also Xen could use. That may change again, the final MSI layer design is not settled yet. Therefore, no concerns from that POV, this work takes longer. We can refactor the Xen hooks during that run again. However, you know that you miss those (uncommon) messages that are injected via DMA? They end up directly in apic_deliver_msi (where KVM will once pick them up as well). Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux