From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41365) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2pdK-0002JW-8T for qemu-devel@nongnu.org; Wed, 29 Feb 2012 14:56:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S2pdH-0003pv-Ra for qemu-devel@nongnu.org; Wed, 29 Feb 2012 14:56:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37872) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2pdH-0003pL-Di for qemu-devel@nongnu.org; Wed, 29 Feb 2012 14:56:15 -0500 Message-ID: <4F4E7E50.4050705@redhat.com> Date: Wed, 29 Feb 2012 12:36:48 -0700 From: Eric Blake MIME-Version: 1.0 References: <1330522650-15357-1-git-send-email-pbonzini@redhat.com> <1330522650-15357-6-git-send-email-pbonzini@redhat.com> In-Reply-To: <1330522650-15357-6-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig5D3B1C60C3CB4DECF68ADFFE" Subject: Re: [Qemu-devel] [PATCH 5/6] Add blkmirror block driver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, stefanha@linux.vnet.ibm.com, jcody@redhat.com, Marcelo Tosatti , qemu-devel@nongnu.org, fsimonce@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig5D3B1C60C3CB4DECF68ADFFE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/29/2012 06:37 AM, Paolo Bonzini wrote: > From: Marcelo Tosatti >=20 > Mirrored writes are used by live block copy. >=20 > The blkmirror driver is for internal use only, because it requires > bdrv_append to set up a backing_hd for it. It relies on a quirk > of bdrv_append, which leaves the old image open for writes. >=20 > The source is hardcoded as the backing_hd for the destination, so that > copy-on-write functions properly. Since the source is not yet availabl= e > at the time blkmirror_open is called, the backing_hd is set later. >=20 > +++ b/block/blkmirror.c > @@ -0,0 +1,153 @@ > +/* > + * Block driver for mirrored writes. > + * > + * Copyright (C) 2011 Red Hat, Inc. It's now 2012; should this be expanded? --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig5D3B1C60C3CB4DECF68ADFFE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPTn5QAAoJEKeha0olJ0NqKqcH/Rn6O97fDlhvxokA72BNLyl0 XSjgwvDGH0aupKhDX4l9xUsMD5rlXP2hRPGsi4jm6NjgjRvlZDq3KkBYbBsUjE6s YUoewI7msZAJL1wX6Gy76VfTt2tI2XwldUJlU7LwYw880V3tkdJWWl3SfocQzG/m /gxStO10P1t3OuA5RTSLGapNwZ+dAuc84sJesx0qv7YzbBfFnHCoTurevEo6tHSr +61MnVACX4mJ1L0N0U0JGTC9maOZS5WYW4JRcG7fju937NDjPLsF3OQFUi/RX0dO jGLUvwiNzh6xapEv0rH4NjOXXFDgl6hLlbq+8XpbYBqeFU6LUk/A+BsMmE0mr4U= =iv8i -----END PGP SIGNATURE----- --------------enig5D3B1C60C3CB4DECF68ADFFE--