From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2pUo-0000Nw-Ks for qemu-devel@nongnu.org; Wed, 29 Feb 2012 14:47:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S2pUj-0000Qr-H5 for qemu-devel@nongnu.org; Wed, 29 Feb 2012 14:47:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:64584) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2pUj-0000QB-8B for qemu-devel@nongnu.org; Wed, 29 Feb 2012 14:47:25 -0500 Message-ID: <4F4E80C8.1010000@redhat.com> Date: Wed, 29 Feb 2012 12:47:20 -0700 From: Eric Blake MIME-Version: 1.0 References: <1330522650-15357-1-git-send-email-pbonzini@redhat.com> <1330522650-15357-7-git-send-email-pbonzini@redhat.com> In-Reply-To: <1330522650-15357-7-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig4AA59D60840860239078C904" Subject: Re: [Qemu-devel] [PATCH 6/6] add mirroring to blockdev-transaction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, fsimonce@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4AA59D60840860239078C904 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/29/2012 06:37 AM, Paolo Bonzini wrote: > Add a new transaction type, "mirror". It stacks a new blkmirror > file (instead of a snapshot) on top of the existing image. >=20 > It is possible to combine snapshot and mirror as two actions in the > same transaction. Because of atomicity ensured by blockdev-transaction= , > this will create a snapshot *and* ensure that _all_ operations that are= > sent to it are also mirrored. >=20 > Signed-off-by: Paolo Bonzini > --- > blockdev.c | 47 +++++++++++++++++++++++++++++++++++-----------= - > qapi-schema.json | 19 ++++++++++++++++++- > qmp-commands.hx | 12 +++++++++++- > 3 files changed, 64 insertions(+), 14 deletions(-) >=20 > @@ -721,6 +725,12 @@ actions array: > - "format": format of new image (json-string, optional) > - "reuse": whether QEMU should look for an existing image file > (json-bool, optional, default false) > + When "type" is "mirror": > + - "device": device name to snapshot (json-string) > + - "target": name of destination image file (json-string) > + - "format": format of new image (json-string, optional) > + - "reuse": whether QEMU should look for an existing image file > + (json-bool, optional, default false) This falls out very nicely. Do we want to also add a 'reopen' operation to the union, for the remaining action needed by oVirt live migration? --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig4AA59D60840860239078C904 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPToDIAAoJEKeha0olJ0NquNwH/0IFdV7woeuw4wVernpjOzh7 H7zofuXeZdCMxxjWgei8CuIIpjpO8ZULikyFSRQwcZ4udlCKYRgVSVTrbYEUZ4s2 Phybociaocq2RQ8Eqk9wQJn6y815xWSr9LKENhggcMOHlP3h/KER6oTIJVL+ooDd TaiRoJ/0wPmDzquj5p34xF8ht6VLjuSDuGLqk7ie9I08FKax11yC431Gc3pDuH2i UGL1qBqwBK0HX7Y6j2m3hwSnFRn0eXyOJrPwlJIKGnAuPV1XRxTNVh7mXkV/FTV3 JKPG6Xo6asxXSHKinEK8p1DyjEvt8Aux0zG4gY/dgzEBfw4yqcRoj/18D2P6ZXs= =GhIb -----END PGP SIGNATURE----- --------------enig4AA59D60840860239078C904--