qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: "Hervé Poussineau" <hpoussin@reactos.org>
Cc: qemu-trivial@nongnu.org, Anthony Liguori <aliguori@us.ibm.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] pc: make user-triggerable exit conditional to DEBUG_BIOS define
Date: Wed, 29 Feb 2012 19:55:05 -0600	[thread overview]
Message-ID: <4F4ED6F9.30109@codemonkey.ws> (raw)
In-Reply-To: <1330555499-11726-1-git-send-email-hpoussin@reactos.org>

On 02/29/2012 04:44 PM, Hervé Poussineau wrote:
> The port 0x501 is (at least) used by SCO Xenix 2.3.4 installer.

For what?  What device would normally be there?

I don't want to disable this by default.  My regression suite depends on this as 
an exit mechanism.

Regards,

Anthony Liguori

>
> Signed-off-by: Hervé Poussineau<hpoussin@reactos.org>
> ---
>   hw/pc.c |    3 +++
>   1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/hw/pc.c b/hw/pc.c
> index 12c02f2..113a38a 100644
> --- a/hw/pc.c
> +++ b/hw/pc.c
> @@ -565,7 +565,10 @@ static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val)
>           /* LGPL'ed VGA BIOS messages */
>       case 0x501:
>       case 0x502:
> +#ifdef DEBUG_BIOS
>           exit((val<<  1) | 1);
> +#endif
> +        break;
>       case 0x500:
>       case 0x503:
>   #ifdef DEBUG_BIOS

  reply	other threads:[~2012-03-01  1:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-29 22:44 [Qemu-devel] [PATCH] pc: make user-triggerable exit conditional to DEBUG_BIOS define Hervé Poussineau
2012-03-01  1:55 ` Anthony Liguori [this message]
2012-03-01  6:42   ` Hervé Poussineau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F4ED6F9.30109@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=aliguori@us.ibm.com \
    --cc=hpoussin@reactos.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).