From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57489)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S2vEg-0006P6-Gr
	for qemu-devel@nongnu.org; Wed, 29 Feb 2012 20:55:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S2vEd-00033s-LL
	for qemu-devel@nongnu.org; Wed, 29 Feb 2012 20:55:14 -0500
Received: from mail-pw0-f45.google.com ([209.85.160.45]:54135)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S2vEd-00031q-Fd
	for qemu-devel@nongnu.org; Wed, 29 Feb 2012 20:55:11 -0500
Received: by pbcuo1 with SMTP id uo1so310296pbc.4
	for <qemu-devel@nongnu.org>; Wed, 29 Feb 2012 17:55:09 -0800 (PST)
Message-ID: <4F4ED6F9.30109@codemonkey.ws>
Date: Wed, 29 Feb 2012 19:55:05 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1330555499-11726-1-git-send-email-hpoussin@reactos.org>
In-Reply-To: <1330555499-11726-1-git-send-email-hpoussin@reactos.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH] pc: make user-triggerable exit conditional
 to DEBUG_BIOS define
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= <hpoussin@reactos.org>
Cc: qemu-trivial@nongnu.org, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

On 02/29/2012 04:44 PM, Hervé Poussineau wrote:
> The port 0x501 is (at least) used by SCO Xenix 2.3.4 installer.

For what?  What device would normally be there?

I don't want to disable this by default.  My regression suite depends on this as 
an exit mechanism.

Regards,

Anthony Liguori

>
> Signed-off-by: Hervé Poussineau<hpoussin@reactos.org>
> ---
>   hw/pc.c |    3 +++
>   1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/hw/pc.c b/hw/pc.c
> index 12c02f2..113a38a 100644
> --- a/hw/pc.c
> +++ b/hw/pc.c
> @@ -565,7 +565,10 @@ static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val)
>           /* LGPL'ed VGA BIOS messages */
>       case 0x501:
>       case 0x502:
> +#ifdef DEBUG_BIOS
>           exit((val<<  1) | 1);
> +#endif
> +        break;
>       case 0x500:
>       case 0x503:
>   #ifdef DEBUG_BIOS