From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60273) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S30Zh-00025X-KK for qemu-devel@nongnu.org; Thu, 01 Mar 2012 02:37:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S30ZJ-0005Yd-2H for qemu-devel@nongnu.org; Thu, 01 Mar 2012 02:37:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54053) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S30ZI-0005Y5-Qg for qemu-devel@nongnu.org; Thu, 01 Mar 2012 02:36:52 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q217apTK009314 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 1 Mar 2012 02:36:51 -0500 Message-ID: <4F4F2710.2010001@redhat.com> Date: Thu, 01 Mar 2012 08:36:48 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <4F4E3090.2050105@redhat.com> In-Reply-To: <4F4E3090.2050105@redhat.com> Content-Type: multipart/mixed; boundary="------------020509030408010903030401" Subject: Re: [Qemu-devel] Broken screendump with unconnected vnc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel This is a multi-part message in MIME format. --------------020509030408010903030401 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 02/29/12 15:05, Avi Kivity wrote: > qemu-system-x86_64 -monitor stdio -vnc :0 > QEMU 1.0.50 monitor - type 'help' for more information > (qemu) screendump /tmp/x.ppm > > display /tmp/x.ppm shows an empty screenshot. Breaks autotest for me. > Connecting a vnc viewer works around the problem. Patch sent. Attached here for convenience as git send-email hasn't picked up Reported-by: for Cc'ing. cheers, Gerd --------------020509030408010903030401 Content-Type: text/plain; name="0001-fix-screendump.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-fix-screendump.patch" RnJvbSBkMzBkMjJmNWE3MWJhNjBkMGJjNzFiNjg3OTc5MWYyMzc3YzcwYTFmIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBHZXJkIEhvZmZtYW5uIDxrcmF4ZWxAcmVkaGF0LmNv bT4KRGF0ZTogVGh1LCAxIE1hciAyMDEyIDA4OjI4OjMyICswMTAwClN1YmplY3Q6IFtQQVRD SF0gZml4IHNjcmVlbmR1bXAKCkNvbW1pdCA0NWVmYjE2MTI0ZWZlZjUxZGU1MTU3YWZjMzE5 ODRiNWE0NzcwMGY5IG9wdGltaXplZCBhIGJpdCB0b28KbXVjaC4gIFdlIGNhbiBza2lwIHRo ZSB2Z2FfaW52YWxpZGF0ZV9kaXNwbGF5KCkgaW4gY2FzZSBubyBjb25zb2xlCnN3aXRjaCBo YXBwZW5lZCBiZWNhdXNlIHdlIGRvbid0IG5lZWQgYSBmdWxsIHJlZHJhdyB0aGVuLiAgV2Ug Y2FuICpub3QqCnNraXAgdmdhX2h3X3VwZGF0ZSgpIHRob3VnaCwgYmVjYXVzZSB0aGUgc2Ny ZWVuIGNvbnRlbnQgd2lsbCBiZSBzdGFsZQp0aGVuIGluIGNhc2Ugbm9ib2R5IGVsc2UgY2Fs bHMgdmdhX2h3X3VwZGF0ZSgpLgoKVHJpZ2dlcjogdmdhIHRleHRtb2RlIHdpdGggdm5jIGRp c3BsYXkgYW5kIG5vIGNsaWVudCBjb25uZWN0ZWQuCgpSZXBvcnRlZC1ieTogQXZpIEtpdml0 eSA8YXZpQHJlZGhhdC5jb20+ClNpZ25lZC1vZmYtYnk6IEdlcmQgSG9mZm1hbm4gPGtyYXhl bEByZWRoYXQuY29tPgotLS0KIGh3L2JsaXp6YXJkLmMgIHwgICAgNCArLS0tCiBody9vbWFw X2xjZGMuYyB8ICAgIDUgKystLS0KIGh3L3ZnYS5jICAgICAgIHwgICAgMiArLQogMyBmaWxl cyBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvaHcvYmxpenphcmQuYyBiL2h3L2JsaXp6YXJkLmMKaW5kZXggYzdkODQ0ZC4uMjkwNzRj NCAxMDA2NDQKLS0tIGEvaHcvYmxpenphcmQuYworKysgYi9ody9ibGl6emFyZC5jCkBAIC05 MzcsOSArOTM3LDcgQEAgc3RhdGljIHZvaWQgYmxpenphcmRfc2NyZWVuX2R1bXAodm9pZCAq b3BhcXVlLCBjb25zdCBjaGFyICpmaWxlbmFtZSwKIHsKICAgICBCbGl6emFyZFN0YXRlICpz ID0gKEJsaXp6YXJkU3RhdGUgKikgb3BhcXVlOwogCi0gICAgaWYgKGNzd2l0Y2gpIHsKLSAg ICAgICAgYmxpenphcmRfdXBkYXRlX2Rpc3BsYXkob3BhcXVlKTsKLSAgICB9CisgICAgYmxp enphcmRfdXBkYXRlX2Rpc3BsYXkob3BhcXVlKTsKICAgICBpZiAocyAmJiBkc19nZXRfZGF0 YShzLT5zdGF0ZSkpCiAgICAgICAgIHBwbV9zYXZlKGZpbGVuYW1lLCBzLT5zdGF0ZS0+c3Vy ZmFjZSk7CiB9CmRpZmYgLS1naXQgYS9ody9vbWFwX2xjZGMuYyBiL2h3L29tYXBfbGNkYy5j CmluZGV4IGYxNzIwOTMuLjRhMDhlOWQgMTAwNjQ0Ci0tLSBhL2h3L29tYXBfbGNkYy5jCisr KyBiL2h3L29tYXBfbGNkYy5jCkBAIC0yNjcsOSArMjY3LDggQEAgc3RhdGljIGludCBwcG1f c2F2ZShjb25zdCBjaGFyICpmaWxlbmFtZSwgdWludDhfdCAqZGF0YSwKIHN0YXRpYyB2b2lk IG9tYXBfc2NyZWVuX2R1bXAodm9pZCAqb3BhcXVlLCBjb25zdCBjaGFyICpmaWxlbmFtZSwg Ym9vbCBjc3dpdGNoKQogewogICAgIHN0cnVjdCBvbWFwX2xjZF9wYW5lbF9zICpvbWFwX2xj ZCA9IG9wYXF1ZTsKLSAgICBpZiAoY3N3aXRjaCkgewotICAgICAgICBvbWFwX3VwZGF0ZV9k aXNwbGF5KG9wYXF1ZSk7Ci0gICAgfQorCisgICAgb21hcF91cGRhdGVfZGlzcGxheShvcGFx dWUpOwogICAgIGlmIChvbWFwX2xjZCAmJiBkc19nZXRfZGF0YShvbWFwX2xjZC0+c3RhdGUp KQogICAgICAgICBwcG1fc2F2ZShmaWxlbmFtZSwgZHNfZ2V0X2RhdGEob21hcF9sY2QtPnN0 YXRlKSwKICAgICAgICAgICAgICAgICBvbWFwX2xjZC0+d2lkdGgsIG9tYXBfbGNkLT5oZWln aHQsCmRpZmYgLS1naXQgYS9ody92Z2EuYyBiL2h3L3ZnYS5jCmluZGV4IDU5OTRmNDMuLjE2 NTQ2ZWYgMTAwNjQ0Ci0tLSBhL2h3L3ZnYS5jCisrKyBiL2h3L3ZnYS5jCkBAIC0yNDEzLDcg KzI0MTMsNyBAQCBzdGF0aWMgdm9pZCB2Z2Ffc2NyZWVuX2R1bXAodm9pZCAqb3BhcXVlLCBj b25zdCBjaGFyICpmaWxlbmFtZSwgYm9vbCBjc3dpdGNoKQogCiAgICAgaWYgKGNzd2l0Y2gp IHsKICAgICAgICAgdmdhX2ludmFsaWRhdGVfZGlzcGxheShzKTsKLSAgICAgICAgdmdhX2h3 X3VwZGF0ZSgpOwogICAgIH0KKyAgICB2Z2FfaHdfdXBkYXRlKCk7CiAgICAgcHBtX3NhdmUo ZmlsZW5hbWUsIHMtPmRzLT5zdXJmYWNlKTsKIH0KLS0gCjEuNy4xCgo= --------------020509030408010903030401--