From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:53775)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1S33lK-0003dz-6R
	for qemu-devel@nongnu.org; Thu, 01 Mar 2012 06:01:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1S33kv-0001W1-Ij
	for qemu-devel@nongnu.org; Thu, 01 Mar 2012 06:01:29 -0500
Received: from mx1.redhat.com ([209.132.183.28]:20189)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1S33kv-0001VJ-Ar
	for qemu-devel@nongnu.org; Thu, 01 Mar 2012 06:01:05 -0500
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q21B12pr003337
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 1 Mar 2012 06:01:02 -0500
Message-ID: <4F4F56CA.4040501@redhat.com>
Date: Thu, 01 Mar 2012 13:00:26 +0200
From: Orit Wasserman <owasserm@redhat.com>
MIME-Version: 1.0
References: <1330435867-17860-1-git-send-email-owasserm@redhat.com>
	<20120301092925.GD2903@amit.redhat.com>
In-Reply-To: <20120301092925.GD2903@amit.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] We should check virtio_load return code
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: pbonzini@redhat.com, Ulrich Obergfell <uobergfe@redhat.com>, qemu-devel@nongnu.org, mst@redhat.com

On 03/01/2012 11:29 AM, Amit Shah wrote:
> On (Tue) 28 Feb 2012 [15:31:07], Orit Wasserman wrote:
>> Otherwise we crash on error.
> 
> A description on how to reproduce the crash would be nice.

We changed the default of the command -device virtio-blk-pci,drive=...
from scsi=on to scsi=off for security reasons (disable SG_IO).
If you try to migrate from an older version (which had the default scsi=on) to a newer version
(that has default scsi=off) we get the crash.

Orit
> 
>> Signed-off-by: Orit Wasserman <owasserm@redhat.com>
>> Signed-off-by: Ulrich Obergfell <uobergfe@redhat.com>
> 
> Acked-by: Amit Shah <amit.shah@redhat.com>
> 
> 		Amit