From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57136) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S33qX-0006Lw-Np for qemu-devel@nongnu.org; Thu, 01 Mar 2012 06:06:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S33qV-0002WF-Mt for qemu-devel@nongnu.org; Thu, 01 Mar 2012 06:06:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:24482) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S33qV-0002Vs-FG for qemu-devel@nongnu.org; Thu, 01 Mar 2012 06:06:51 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q21B6npl002746 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 1 Mar 2012 06:06:49 -0500 Message-ID: <4F4F5847.3030201@redhat.com> Date: Thu, 01 Mar 2012 13:06:47 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1330587280-13038-1-git-send-email-kraxel@redhat.com> In-Reply-To: <1330587280-13038-1-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] fix screendump List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On 03/01/2012 09:34 AM, Gerd Hoffmann wrote: > Commit 45efb16124efef51de5157afc31984b5a47700f9 optimized a bit too > much. We can skip the vga_invalidate_display() in case no console > switch happened because we don't need a full redraw then. We can *not* > skip vga_hw_update() though, because the screen content will be stale > then in case nobody else calls vga_hw_update(). > > Trigger: vga textmode with vnc display and no client connected. > > Reported-by: Avi Kivity -and-Tested. Thanks. > Signed-off-by: Gerd Hoffmann > -- error compiling committee.c: too many arguments to function