From: Paolo Bonzini <pbonzini@redhat.com>
To: Orit Wasserman <owasserm@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>,
Ulrich Obergfell <uobergfe@redhat.com>,
qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH] We should check virtio_load return code
Date: Thu, 01 Mar 2012 12:14:12 +0100 [thread overview]
Message-ID: <4F4F5A04.4040006@redhat.com> (raw)
In-Reply-To: <4F4F56CA.4040501@redhat.com>
Il 01/03/2012 12:00, Orit Wasserman ha scritto:
>> > A description on how to reproduce the crash would be nice.
> We changed the default of the command -device virtio-blk-pci,drive=...
> from scsi=on to scsi=off for security reasons (disable SG_IO).
> If you try to migrate from an older version (which had the default scsi=on) to a newer version
> (that has default scsi=off) we get the crash.
Actually the default didn't change in QEMU. It's libvirt that changed
the command-line with which it invokes QEMU.
This patch fixes the crash, I'll post one to fix migration later.
Paolo
prev parent reply other threads:[~2012-03-01 11:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 13:31 [Qemu-devel] [PATCH] We should check virtio_load return code Orit Wasserman
2012-02-28 13:40 ` Paolo Bonzini
2012-03-01 9:29 ` Amit Shah
2012-03-01 9:56 ` Markus Armbruster
2012-03-01 11:00 ` Orit Wasserman
2012-03-01 11:14 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4F5A04.4040006@redhat.com \
--to=pbonzini@redhat.com \
--cc=amit.shah@redhat.com \
--cc=mst@redhat.com \
--cc=owasserm@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=uobergfe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).