From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:53926)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1S33y9-0008OI-8t
	for qemu-devel@nongnu.org; Thu, 01 Mar 2012 06:14:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1S33xk-00045R-SJ
	for qemu-devel@nongnu.org; Thu, 01 Mar 2012 06:14:44 -0500
Received: from mx1.redhat.com ([209.132.183.28]:11644)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1S33xk-00045D-JX
	for qemu-devel@nongnu.org; Thu, 01 Mar 2012 06:14:20 -0500
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q21BEIuE026603
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 1 Mar 2012 06:14:19 -0500
Message-ID: <4F4F5A04.4040006@redhat.com>
Date: Thu, 01 Mar 2012 12:14:12 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1330435867-17860-1-git-send-email-owasserm@redhat.com>
	<20120301092925.GD2903@amit.redhat.com>
	<4F4F56CA.4040501@redhat.com>
In-Reply-To: <4F4F56CA.4040501@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] We should check virtio_load return code
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Orit Wasserman <owasserm@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>, Ulrich Obergfell <uobergfe@redhat.com>, qemu-devel@nongnu.org, mst@redhat.com

Il 01/03/2012 12:00, Orit Wasserman ha scritto:
>> > A description on how to reproduce the crash would be nice.
> We changed the default of the command -device virtio-blk-pci,drive=...
> from scsi=on to scsi=off for security reasons (disable SG_IO).
> If you try to migrate from an older version (which had the default scsi=on) to a newer version
> (that has default scsi=off) we get the crash.

Actually the default didn't change in QEMU.  It's libvirt that changed
the command-line with which it invokes QEMU.

This patch fixes the crash, I'll post one to fix migration later.

Paolo