[Qemu-devel] [PULL] kvm updates

[Qemu-devel] [PULL] kvm updates

[Avi Kivity]

This batch of updates is mostly Jan's rework of qemu-kvm's TPR
optimization for 32-bit Windows, making Windows XP much faster with kvm
enabled on older Intel and any AMD hardware.  Any similarities to the
original hack are purely coincidental.

Please pull from:

  git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master

----------------------------------------------------------------
Avi Kivity (1):
      pc-bios: update kvmvapic.bin

Gleb Natapov (1):
      kvm: Synchronize cpu state in kvm_arch_stop_on_emulation_error()

Jan Kiszka (10):
      kvm: Set cpu_single_env only once
      Remove useless casts from cpu iterators
      Process pending work while waiting for initial kick-off in TCG mode
      Allow to use pause_all_vcpus from VCPU context
      target-i386: Add infrastructure for reporting TPR MMIO accesses
      kvmvapic: Add option ROM
      kvmvapic: Introduce TPR access optimization for Windows guests
      kvmvapic: Simplify mp/up_set_tpr
      optionsrom: Reserve space for checksum
      kvmvapic: Use optionrom helpers

 .gitignore                    |    1 +
 Makefile                      |    2 +-
 Makefile.target               |    3 +-
 cpu-all.h                     |    3 +-
 cpus.c                        |   26 ++-
 hw/apic.c                     |  126 ++++++-
 hw/apic.h                     |    2 +
 hw/apic_common.c              |   69 ++++-
 hw/apic_internal.h            |   27 ++
 hw/kvm/apic.c                 |   32 ++
 hw/kvmvapic.c                 |  805
+++++++++++++++++++++++++++++++++++++++++
 hw/mc146818rtc.c              |    5 +-
 kvm-all.c                     |    5 -
 pc-bios/kvmvapic.bin          |  Bin 0 -> 9216 bytes
 pc-bios/optionrom/Makefile    |    2 +-
 pc-bios/optionrom/kvmvapic.S  |  335 +++++++++++++++++
 pc-bios/optionrom/optionrom.h |    3 +-
 target-i386/cpu.h             |   10 +
 target-i386/helper.c          |   16 +
 target-i386/kvm.c             |   26 ++-
 20 files changed, 1468 insertions(+), 30 deletions(-)
 create mode 100644 hw/kvmvapic.c
 create mode 100755 pc-bios/kvmvapic.bin
 create mode 100644 pc-bios/optionrom/kvmvapic.S

-- 
error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PULL] kvm updates

[Andreas Färber]

Am 01.03.2012 13:47, schrieb Avi Kivity:
> Avi Kivity (1):
>       pc-bios: update kvmvapic.bin
> 
> Gleb Natapov (1):
>       kvm: Synchronize cpu state in kvm_arch_stop_on_emulation_error()
> 
> Jan Kiszka (10):
>       kvm: Set cpu_single_env only once
>       Remove useless casts from cpu iterators
>       Process pending work while waiting for initial kick-off in TCG mode
>       Allow to use pause_all_vcpus from VCPU context
>       target-i386: Add infrastructure for reporting TPR MMIO accesses
>       kvmvapic: Add option ROM
>       kvmvapic: Introduce TPR access optimization for Windows guests
>       kvmvapic: Simplify mp/up_set_tpr
>       optionsrom: Reserve space for checksum
>       kvmvapic: Use optionrom helpers

What about my kvmclock kvm_enabled() fix? Should I rather submit that as
part of my qom-cpu queue? It depends on it.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [PULL] kvm updates

[Avi Kivity]

On 03/02/2012 01:45 AM, Andreas Färber wrote:
> Am 01.03.2012 13:47, schrieb Avi Kivity:
> > Avi Kivity (1):
> >       pc-bios: update kvmvapic.bin
> > 
> > Gleb Natapov (1):
> >       kvm: Synchronize cpu state in kvm_arch_stop_on_emulation_error()
> > 
> > Jan Kiszka (10):
> >       kvm: Set cpu_single_env only once
> >       Remove useless casts from cpu iterators
> >       Process pending work while waiting for initial kick-off in TCG mode
> >       Allow to use pause_all_vcpus from VCPU context
> >       target-i386: Add infrastructure for reporting TPR MMIO accesses
> >       kvmvapic: Add option ROM
> >       kvmvapic: Introduce TPR access optimization for Windows guests
> >       kvmvapic: Simplify mp/up_set_tpr
> >       optionsrom: Reserve space for checksum
> >       kvmvapic: Use optionrom helpers
>
> What about my kvmclock kvm_enabled() fix? Should I rather submit that as
> part of my qom-cpu queue? It depends on it.

I am still catching up with my queue post vacation.  Somehow it seems to
be getting longer instead of shorter.

-- 
error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PULL] kvm updates

[Anthony Liguori]

On 03/01/2012 06:47 AM, Avi Kivity wrote:
> This batch of updates is mostly Jan's rework of qemu-kvm's TPR
> optimization for 32-bit Windows, making Windows XP much faster with kvm
> enabled on older Intel and any AMD hardware.  Any similarities to the
> original hack are purely coincidental.
>
> Please pull from:
>
>    git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master

Pulled.  Thanks.

Regards,

Anthony Liguori

>
> ----------------------------------------------------------------
> Avi Kivity (1):
>        pc-bios: update kvmvapic.bin
>
> Gleb Natapov (1):
>        kvm: Synchronize cpu state in kvm_arch_stop_on_emulation_error()
>
> Jan Kiszka (10):
>        kvm: Set cpu_single_env only once
>        Remove useless casts from cpu iterators
>        Process pending work while waiting for initial kick-off in TCG mode
>        Allow to use pause_all_vcpus from VCPU context
>        target-i386: Add infrastructure for reporting TPR MMIO accesses
>        kvmvapic: Add option ROM
>        kvmvapic: Introduce TPR access optimization for Windows guests
>        kvmvapic: Simplify mp/up_set_tpr
>        optionsrom: Reserve space for checksum
>        kvmvapic: Use optionrom helpers
>
>   .gitignore                    |    1 +
>   Makefile                      |    2 +-
>   Makefile.target               |    3 +-
>   cpu-all.h                     |    3 +-
>   cpus.c                        |   26 ++-
>   hw/apic.c                     |  126 ++++++-
>   hw/apic.h                     |    2 +
>   hw/apic_common.c              |   69 ++++-
>   hw/apic_internal.h            |   27 ++
>   hw/kvm/apic.c                 |   32 ++
>   hw/kvmvapic.c                 |  805
> +++++++++++++++++++++++++++++++++++++++++
>   hw/mc146818rtc.c              |    5 +-
>   kvm-all.c                     |    5 -
>   pc-bios/kvmvapic.bin          |  Bin 0 ->  9216 bytes
>   pc-bios/optionrom/Makefile    |    2 +-
>   pc-bios/optionrom/kvmvapic.S  |  335 +++++++++++++++++
>   pc-bios/optionrom/optionrom.h |    3 +-
>   target-i386/cpu.h             |   10 +
>   target-i386/helper.c          |   16 +
>   target-i386/kvm.c             |   26 ++-
>   20 files changed, 1468 insertions(+), 30 deletions(-)
>   create mode 100644 hw/kvmvapic.c
>   create mode 100755 pc-bios/kvmvapic.bin
>   create mode 100644 pc-bios/optionrom/kvmvapic.S
>

[Qemu-devel] [PULL] kvm updates

[Avi Kivity]

Please pull from:

  git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master

to fix a bug in kvm PIT time synchronization and a bug in kvm apic reset.

----------------------------------------------------------------
Jan Kiszka (1):
      kvm: i8254: Fix conversion of in-kernel to userspace state

Jim Meyering (1):
      kvm/apic: correct short memset

 hw/kvm/apic.c  |    2 +-
 hw/kvm/i8254.c |   57
++++++++++++++++++++++++++++++++++++++++++++++++++++-----
-- 
error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PULL] kvm updates

[Anthony Liguori]

On 06/11/2012 08:38 AM, Avi Kivity wrote:
> Please pull from:
>
>    git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master
>
> to fix a bug in kvm PIT time synchronization and a bug in kvm apic reset.

Pulled.  Thanks.

Regards,

Anthony Liguori

>
> ----------------------------------------------------------------
> Jan Kiszka (1):
>        kvm: i8254: Fix conversion of in-kernel to userspace state
>
> Jim Meyering (1):
>        kvm/apic: correct short memset
>
>   hw/kvm/apic.c  |    2 +-
>   hw/kvm/i8254.c |   57
> ++++++++++++++++++++++++++++++++++++++++++++++++++++-----

[Qemu-devel] [PULL] kvm updates

[Avi Kivity]

Please pull from:

  git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master

This is mostly Peter's kvm_irqchip_in_kernel() decoupling work.

----------------------------------------------------------------
Dunrong Huang (1):
      kvm: Check if smp_cpus exceeds max cpus supported by kvm

Peter Maydell (8):
      configure: Don't implicitly hardcode list of KVM architectures
      kvm: Decouple 'async interrupt delivery' from 'kernel irqchip'
      kvm: Rename kvm_irqchip_set_irq() to kvm_set_irq()
      kvm: Move kvm_allows_irq0_override() to target-i386, fix return type
      kvm: Decouple 'irqfds usable' from 'kernel irqchip'
      kvm: Decouple 'MSI routing via irqfds' from 'kernel irqchip'
      kvm: Decouple 'GSI routing' from 'kernel irqchip'
      kvm: Add documentation comment for kvm_irqchip_in_kernel()

 configure                 | 14 +++++++++++---
 cpus.c                    |  3 ++-
 hw/kvm/i8259.c            |  2 +-
 hw/kvm/ioapic.c           |  2 +-
 hw/pc.c                   |  1 +
 hw/virtio-pci.c           |  4 ++--
 kvm-all.c                 | 54 +++++++++++++++++++++++++++++++++++++++++++-----------
 kvm-stub.c                |  9 ++++-----
 kvm.h                     | 60 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++---
 target-i386/Makefile.objs |  1 +
 target-i386/kvm-stub.c    | 18 ++++++++++++++++++
 target-i386/kvm.c         | 13 +++++++++++++
 target-i386/kvm_i386.h    | 16 ++++++++++++++++
 13 files changed, 170 insertions(+), 27 deletions(-)
 create mode 100644 target-i386/kvm-stub.c
 create mode 100644 target-i386/kvm_i386.h

-- 
error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PULL] kvm updates

[Anthony Liguori]

Avi Kivity <avi@redhat.com> writes:

> Please pull from:
>
>   git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master

Pulled. Thanks.

Regards,

Anthony Liguori

>
> This is mostly Peter's kvm_irqchip_in_kernel() decoupling work.
>
> ----------------------------------------------------------------
> Dunrong Huang (1):
>       kvm: Check if smp_cpus exceeds max cpus supported by kvm
>
> Peter Maydell (8):
>       configure: Don't implicitly hardcode list of KVM architectures
>       kvm: Decouple 'async interrupt delivery' from 'kernel irqchip'
>       kvm: Rename kvm_irqchip_set_irq() to kvm_set_irq()
>       kvm: Move kvm_allows_irq0_override() to target-i386, fix return type
>       kvm: Decouple 'irqfds usable' from 'kernel irqchip'
>       kvm: Decouple 'MSI routing via irqfds' from 'kernel irqchip'
>       kvm: Decouple 'GSI routing' from 'kernel irqchip'
>       kvm: Add documentation comment for kvm_irqchip_in_kernel()
>
>  configure                 | 14 +++++++++++---
>  cpus.c                    |  3 ++-
>  hw/kvm/i8259.c            |  2 +-
>  hw/kvm/ioapic.c           |  2 +-
>  hw/pc.c                   |  1 +
>  hw/virtio-pci.c           |  4 ++--
>  kvm-all.c                 | 54 +++++++++++++++++++++++++++++++++++++++++++-----------
>  kvm-stub.c                |  9 ++++-----
>  kvm.h                     | 60 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++---
>  target-i386/Makefile.objs |  1 +
>  target-i386/kvm-stub.c    | 18 ++++++++++++++++++
>  target-i386/kvm.c         | 13 +++++++++++++
>  target-i386/kvm_i386.h    | 16 ++++++++++++++++
>  13 files changed, 170 insertions(+), 27 deletions(-)
>  create mode 100644 target-i386/kvm-stub.c
>  create mode 100644 target-i386/kvm_i386.h
>
> -- 
> error compiling committee.c: too many arguments to function

[Qemu-devel] [PULL] KVM updates

[Avi Kivity]

Please pull from:

  git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master

to merge some kvm updates, most notably a port of qemu-kvm's pre-vfio device
assignment.  With this there are no significant changes left between qemu and
qemu-kvm (though some work remains).

----------------------------------------------------------------
Christian Borntraeger (1):
      qemu: Use valgrind annotations to mark kvm guest memory as defined

Jan Kiszka (5):
      kvm: Clean up irqfd API
      kvm: Introduce kvm_irqchip_update_msi_route
      kvm: Introduce kvm_has_intx_set_mask
      kvm: i386: Add services required for PCI device assignment
      kvm: i386: Add classic PCI device assignment

 configure              |    3 +-
 hw/kvm/Makefile.objs   |    2 +-
 hw/kvm/pci-assign.c    | 1915 ++++++++++++++++++++++++++++++++++++++++++++++++
 hw/qdev-monitor.c      |    1 +
 hw/virtio-pci.c        |    4 +-
 kvm-all.c              |   75 +-
 kvm-stub.c             |   14 +-
 kvm.h                  |    8 +-
 target-i386/kvm.c      |  141 ++++
 target-i386/kvm_i386.h |   22 +
 10 files changed, 2151 insertions(+), 34 deletions(-)
 create mode 100644 hw/kvm/pci-assign.c

-- 
error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PULL] KVM updates

[Jan Kiszka]

On 2012-09-10 17:25, Avi Kivity wrote:
> Please pull from:
> 
>   git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master
> 
> to merge some kvm updates, most notably a port of qemu-kvm's pre-vfio device
> assignment.  With this there are no significant changes left between qemu and
> qemu-kvm (though some work remains).
> 
> ----------------------------------------------------------------
> Christian Borntraeger (1):
>       qemu: Use valgrind annotations to mark kvm guest memory as defined
> 
> Jan Kiszka (5):
>       kvm: Clean up irqfd API
>       kvm: Introduce kvm_irqchip_update_msi_route
>       kvm: Introduce kvm_has_intx_set_mask
>       kvm: i386: Add services required for PCI device assignment
>       kvm: i386: Add classic PCI device assignment

uq/master used to contain two patches from Peter regarding the kernel
headers and my coalesced MMIO decoupling series - dropped intentionally?

Jan

> 
>  configure              |    3 +-
>  hw/kvm/Makefile.objs   |    2 +-
>  hw/kvm/pci-assign.c    | 1915 ++++++++++++++++++++++++++++++++++++++++++++++++
>  hw/qdev-monitor.c      |    1 +
>  hw/virtio-pci.c        |    4 +-
>  kvm-all.c              |   75 +-
>  kvm-stub.c             |   14 +-
>  kvm.h                  |    8 +-
>  target-i386/kvm.c      |  141 ++++
>  target-i386/kvm_i386.h |   22 +
>  10 files changed, 2151 insertions(+), 34 deletions(-)
>  create mode 100644 hw/kvm/pci-assign.c
> 

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux

Re: [Qemu-devel] [PULL] KVM updates

[Marcelo Tosatti]

On Mon, Sep 10, 2012 at 05:32:39PM +0200, Jan Kiszka wrote:
> On 2012-09-10 17:25, Avi Kivity wrote:
> > Please pull from:
> > 
> >   git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master
> > 
> > to merge some kvm updates, most notably a port of qemu-kvm's pre-vfio device
> > assignment.  With this there are no significant changes left between qemu and
> > qemu-kvm (though some work remains).
> > 
> > ----------------------------------------------------------------
> > Christian Borntraeger (1):
> >       qemu: Use valgrind annotations to mark kvm guest memory as defined
> > 
> > Jan Kiszka (5):
> >       kvm: Clean up irqfd API
> >       kvm: Introduce kvm_irqchip_update_msi_route
> >       kvm: Introduce kvm_has_intx_set_mask
> >       kvm: i386: Add services required for PCI device assignment
> >       kvm: i386: Add classic PCI device assignment
> 
> uq/master used to contain two patches from Peter regarding the kernel
> headers and my coalesced MMIO decoupling series - dropped intentionally?
> 
> Jan

Probably unintentionally, they havent been lost though (will be in the
next batch once this batch is pulled).

Re: [Qemu-devel] [PULL] KVM updates

[Avi Kivity]

On 09/10/2012 06:49 PM, Marcelo Tosatti wrote:
> On Mon, Sep 10, 2012 at 05:32:39PM +0200, Jan Kiszka wrote:
>> On 2012-09-10 17:25, Avi Kivity wrote:
>> > Please pull from:
>> > 
>> >   git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master
>> > 
>> > to merge some kvm updates, most notably a port of qemu-kvm's pre-vfio device
>> > assignment.  With this there are no significant changes left between qemu and
>> > qemu-kvm (though some work remains).
>> > 
>> > ----------------------------------------------------------------
>> > Christian Borntraeger (1):
>> >       qemu: Use valgrind annotations to mark kvm guest memory as defined
>> > 
>> > Jan Kiszka (5):
>> >       kvm: Clean up irqfd API
>> >       kvm: Introduce kvm_irqchip_update_msi_route
>> >       kvm: Introduce kvm_has_intx_set_mask
>> >       kvm: i386: Add services required for PCI device assignment
>> >       kvm: i386: Add classic PCI device assignment
>> 
>> uq/master used to contain two patches from Peter regarding the kernel
>> headers and my coalesced MMIO decoupling series - dropped intentionally?

Thanks for checking.

> Probably unintentionally, they havent been lost though (will be in the
> next batch once this batch is pulled).

Any idea how they were lost?

-- 
error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PULL] KVM updates

[Anthony Liguori]

Avi Kivity <avi@redhat.com> writes:

> Please pull from:
>
>   git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master
>
> to merge some kvm updates, most notably a port of qemu-kvm's pre-vfio device
> assignment.  With this there are no significant changes left between qemu and
> qemu-kvm (though some work remains).

Pulled. Thanks.

I took a look at the difference, appears to be some deprecated options
and CPU hotplug.  What's the plan there?

Is CPU hotplug functional in qemu-kvm?

Regards,

Anthony Liguori

>
> ----------------------------------------------------------------
> Christian Borntraeger (1):
>       qemu: Use valgrind annotations to mark kvm guest memory as defined
>
> Jan Kiszka (5):
>       kvm: Clean up irqfd API
>       kvm: Introduce kvm_irqchip_update_msi_route
>       kvm: Introduce kvm_has_intx_set_mask
>       kvm: i386: Add services required for PCI device assignment
>       kvm: i386: Add classic PCI device assignment
>
>  configure              |    3 +-
>  hw/kvm/Makefile.objs   |    2 +-
>  hw/kvm/pci-assign.c    | 1915 ++++++++++++++++++++++++++++++++++++++++++++++++
>  hw/qdev-monitor.c      |    1 +
>  hw/virtio-pci.c        |    4 +-
>  kvm-all.c              |   75 +-
>  kvm-stub.c             |   14 +-
>  kvm.h                  |    8 +-
>  target-i386/kvm.c      |  141 ++++
>  target-i386/kvm_i386.h |   22 +
>  10 files changed, 2151 insertions(+), 34 deletions(-)
>  create mode 100644 hw/kvm/pci-assign.c
>
> -- 
> error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PULL] KVM updates

[Avi Kivity]

On 09/11/2012 02:03 AM, Anthony Liguori wrote:
> Avi Kivity <avi@redhat.com> writes:
> 
>> Please pull from:
>>
>>   git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master
>>
>> to merge some kvm updates, most notably a port of qemu-kvm's pre-vfio device
>> assignment.  With this there are no significant changes left between qemu and
>> qemu-kvm (though some work remains).
> 
> Pulled. Thanks.
> 
> I took a look at the difference, appears to be some deprecated options
> and CPU hotplug.  What's the plan there?

#include <jan.h>?

> Is CPU hotplug functional in qemu-kvm?

Last I tested, yes.  But it was a long time ago and it isn't part of my
autotest runs.

-- 
error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PULL] KVM updates

[Jan Kiszka]

On 2012-09-11 10:50, Avi Kivity wrote:
> On 09/11/2012 02:03 AM, Anthony Liguori wrote:
>> Avi Kivity <avi@redhat.com> writes:
>>
>>> Please pull from:
>>>
>>>   git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master
>>>
>>> to merge some kvm updates, most notably a port of qemu-kvm's pre-vfio device
>>> assignment.  With this there are no significant changes left between qemu and
>>> qemu-kvm (though some work remains).
>>
>> Pulled. Thanks.
>>
>> I took a look at the difference, appears to be some deprecated options
>> and CPU hotplug.  What's the plan there?
> 
> #include <jan.h>?

No more plans on my side, qemu-kvm is dead here. The only thing worth
pushing in one way or the other is the testdev, to keep autotest happy.
But it's not on my agenda.

> 
>> Is CPU hotplug functional in qemu-kvm?
> 
> Last I tested, yes.  But it was a long time ago and it isn't part of my
> autotest runs.

CPU hotplug became broken years ago in qemu-kvm, I think with the
introduction of qdev to the APIC (and attaching the APIC to the
non-hotpluggable sysbus). There is ongoing work over upstream to make
CPU devices pluggable, and the remaining (unused) delta in acpi_piix4.c
will likely then be transferred as well.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux