From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39870) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S3696-0001dF-Ka for qemu-devel@nongnu.org; Thu, 01 Mar 2012 08:34:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S3690-00025E-DO for qemu-devel@nongnu.org; Thu, 01 Mar 2012 08:34:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44688) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S3690-000256-4d for qemu-devel@nongnu.org; Thu, 01 Mar 2012 08:34:06 -0500 Message-ID: <4F4F7AC7.9050005@redhat.com> Date: Thu, 01 Mar 2012 14:33:59 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1330522650-15357-1-git-send-email-pbonzini@redhat.com> <1330522650-15357-4-git-send-email-pbonzini@redhat.com> <4F4E3559.3010801@redhat.com> <20120229120842.6866b559@doriath.home> <4F4E42E8.8060003@redhat.com> <20120301103015.32ac019d@doriath.home> In-Reply-To: <20120301103015.32ac019d@doriath.home> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/6] rename blockdev-group-snapshot-sync List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Kevin Wolf , Stefan Hajnoczi , Jeff Cody , qemu-devel , Federico Simoncelli , Eric Blake Il 01/03/2012 14:30, Luiz Capitulino ha scritto: >> > My understanding was that in this case I can trust the value to be >> > all-zeros (zero, false, 0.0, NULL), at least in the context of QAPI. >> > The QmpInputVisitor uses g_malloc0. > Yes, as a side effect :) I mean, I don't think the reason for using g_malloc0() > was to have optionals zeroed. If we're going to count on this, then it's > better to make it explicit and/or document it. I removed the assumption from v2 anyway. Paolo