From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36108) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S36N8-0004TK-Fa for qemu-devel@nongnu.org; Thu, 01 Mar 2012 08:49:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S36N2-0005Nx-2n for qemu-devel@nongnu.org; Thu, 01 Mar 2012 08:48:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51353) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S36N1-0005Np-Qu for qemu-devel@nongnu.org; Thu, 01 Mar 2012 08:48:36 -0500 Message-ID: <4F4F7F02.5080603@redhat.com> Date: Thu, 01 Mar 2012 14:52:02 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1330600908-16202-1-git-send-email-pbonzini@redhat.com> <1330600908-16202-3-git-send-email-pbonzini@redhat.com> In-Reply-To: <1330600908-16202-3-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2/6] qapi: complete implementation of unions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: stefanha@linux.vnet.ibm.com, jcody@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, fsimonce@redhat.com, eblake@redhat.com Am 01.03.2012 12:21, schrieb Paolo Bonzini: > Signed-off-by: Paolo Bonzini > --- > qapi-schema-test.json | 10 ++++++++++ > scripts/qapi-types.py | 5 +++++ > scripts/qapi-visit.py | 31 ++++++++++++++++++++++++++++++- > test-qmp-input-visitor.c | 18 ++++++++++++++++++ > test-qmp-output-visitor.c | 34 ++++++++++++++++++++++++++++++++++ > 5 files changed, 97 insertions(+), 1 deletions(-) Makes sense to me, but before applying this patch I'd like to get an Acked-by from Luiz. Kevin