From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43439) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S37kF-0007WX-8w for qemu-devel@nongnu.org; Thu, 01 Mar 2012 10:16:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S37k5-0003FZ-B8 for qemu-devel@nongnu.org; Thu, 01 Mar 2012 10:16:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:4751) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S37k5-0003FI-2a for qemu-devel@nongnu.org; Thu, 01 Mar 2012 10:16:29 -0500 Message-ID: <4F4F92C9.3050406@redhat.com> Date: Thu, 01 Mar 2012 08:16:25 -0700 From: Eric Blake MIME-Version: 1.0 References: <1330612087-1882-1-git-send-email-marcandre.lureau@redhat.com> <1330612087-1882-4-git-send-email-marcandre.lureau@redhat.com> In-Reply-To: <1330612087-1882-4-git-send-email-marcandre.lureau@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig09AA446D6C6A7F0D80EAD773" Subject: Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of 1^32-1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Cc: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , qemu-devel@nongnu.org, kraxel@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig09AA446D6C6A7F0D80EAD773 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/01/2012 07:27 AM, Marc-Andr=C3=A9 Lureau wrote: > So we can easily fit it into smaller int. Fix your subject. 1^32-1 is 0; you meant 2^32 - 1. >=20 > We can just >>16 to fit it into a 16bits volume range for example. > --- > audio/audio.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/audio/audio.c b/audio/audio.c > index bd9237e..9ea5b39 100644 > --- a/audio/audio.c > +++ b/audio/audio.c > @@ -110,8 +110,8 @@ const struct mixeng_volume nominal_volume =3D { > .r =3D 1.0, > .l =3D 1.0, > #else > - .r =3D 1ULL << 32, > - .l =3D 1ULL << 32, > + .r =3D (1ULL << 32) - 1, > + .l =3D (1ULL << 32) - 1, > #endif > }; > =20 --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig09AA446D6C6A7F0D80EAD773 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPT5LKAAoJEKeha0olJ0Nqjo4IAKwXWLQBaeOoHhsyDOK7xtiB VQWIOdhZ0evtLB5AhZ3nPIEXpvSHd5pnw5FfwX+NlZvQD8zJ7RcNZRy93o/dNJUW xmiGobUfjNYraCzhXVmqDFQnJo84iMa//cYpNyQ48pslOnna4N9hVkq41lzUzL3Z /SxYT6hEIvIpwxYpZrDSPnkeXyb8S2cBcay7iI2qKg/QcZ8jKvQVp6SPiFh5cs6G jqYzn1ybIpmt4lWtAop2WQomIjozERjD3DdIMz3XZLHSx8Nno0Fq6a5dBm0z8sqg EWCsyHAM/tG7zU1GlBWWCYHzAvDQbN8zTtoc0rCf0zQ9MjDTWG9uGcYktLTjPZM= =kInk -----END PGP SIGNATURE----- --------------enig09AA446D6C6A7F0D80EAD773--