From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:53799)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1S39Zk-00014U-EV
	for qemu-devel@nongnu.org; Thu, 01 Mar 2012 12:14:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1S39Zb-00070e-4Y
	for qemu-devel@nongnu.org; Thu, 01 Mar 2012 12:13:55 -0500
Received: from mx1.redhat.com ([209.132.183.28]:4566)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1S39Za-00070O-Si
	for qemu-devel@nongnu.org; Thu, 01 Mar 2012 12:13:47 -0500
Message-ID: <4F4FAE42.7010103@redhat.com>
Date: Thu, 01 Mar 2012 19:13:38 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <4F4F7C47.6090005@redhat.com>
	<CAArOQ2VQ9iSeWcAqK9pDH78SmC=Pzv_ErUbEqC9n57=aX7Y+Pg@mail.gmail.com>
	<4F4FABD7.1030709@redhat.com> <4F4FAD1F.7080603@redhat.com>
In-Reply-To: <4F4FAD1F.7080603@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL] Urgent memory fix for kvm with unaligned
 memory slots
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Anthony Liguori <anthony@codemonkey.ws>, qemu-devel <qemu-devel@nongnu.org>, Bobby Powers <bobbypowers@gmail.com>, KVM list <kvm@vger.kernel.org>

On 03/01/2012 07:08 PM, Eric Blake wrote:
> On 03/01/2012 10:03 AM, Avi Kivity wrote:
> >>>
> >>> -    ram = memory_region_get_ram_ptr(mr) + section->offset_within_region;
> >>> +    ram = memory_region_get_ram_ptr(mr) + section->offset_within_region
> >>> + delta;
> >>
> >> Am I crazy, or does this look wrong?
> > 
> > Could be both.  Why do you thing it is wrong?
>
> Line wrapping makes it look like we are adding two lines, one line
> ending in 'section->offset_within_region', and the next line starting
> with 'delta;', which is a syntax error.
>
> But without line wrapping, we are adding just one line with
> 'offset_within_region + delta;' at the end of that line.
>

Ah, of course.  I just copy/pasted this into thunderbird, this is not a
proper patch but a pull request.  Sorry about the confusion.

Bobby: so it does indeed look wrong.  This says nothing about your
sanity though, for that consult a qualified professional instead of
asking on the mailing list.

-- 
error compiling committee.c: too many arguments to function