From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38430)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1S3JKP-0001JH-Lv
	for qemu-devel@nongnu.org; Thu, 01 Mar 2012 22:38:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1S3JKO-0001Ai-0c
	for qemu-devel@nongnu.org; Thu, 01 Mar 2012 22:38:45 -0500
Received: from mx1.redhat.com ([209.132.183.28]:16384)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1S3JKN-0001Ac-P9
	for qemu-devel@nongnu.org; Thu, 01 Mar 2012 22:38:43 -0500
Message-ID: <4F5040BE.2000807@redhat.com>
Date: Fri, 02 Mar 2012 11:38:38 +0800
From: Amos Kong <akong@redhat.com>
MIME-Version: 1.0
References: <20120210062608.13397.43361.stgit@dhcp-8-167.nay.redhat.com>
	<20120210062719.13397.9953.stgit@dhcp-8-167.nay.redhat.com>
	<4F475874.8050803@redhat.com>
In-Reply-To: <4F475874.8050803@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/4] net: split hostname and service by
 last colon
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: aliguori@us.ibm.com, kvm@vger.kernel.org, quintela@redhat.com, jasowang@redhat.com, qemu-devel@nongnu.org, laine@redhat.com

On 24/02/12 17:29, Kevin Wolf wrote:
> Am 10.02.2012 07:27, schrieb Amos Kong:
>> IPv6 address contains colons, parse will be wrong.
>>
>>      [2312::8274]:5200
>>
>> Signed-off-by: Amos Kong<akong@redhat.com>
>> ---
>>   net.c |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/net.c b/net.c
>> index f63014c..9e1ef9e 100644
>> --- a/net.c
>> +++ b/net.c
>> @@ -84,7 +84,7 @@ static int get_str_sep(char *buf, int buf_size, const char **pp, int sep)
>>       const char *p, *p1;
>>       int len;
>>       p = *pp;
>> -    p1 = strchr(p, sep);
>> +    p1 = strrchr(p, sep);
>>       if (!p1)
>>           return -1;
>>       len = p1 - p;
>
> And what if the port isn't specified? I think you would erroneously
> interpret the last part of the IP address as port.

IPv6 address have paired colons, need more precision check.

-- 
			Amos.