Re: [Qemu-devel] Bug#660154: qemu-keymaps: Finnish keyboard mapping broken

Re: [Qemu-devel] Bug#660154: qemu-keymaps: Finnish keyboard mapping broken

[Michael Tokarev]

On 17.02.2012 01:58, Timo Sirainen wrote:
> Subject: qemu-keymaps: Finnish keyboard mapping broken
> Package: qemu-keymaps
> Version: 1.0+dfsg-3
> Severity: normal
> 
> With "-k fi -vnc :1" the keyboard layout works pretty well, except the key between left shift and "z" key, which generates <> characters doesn't work. Instead of "<" it shows "z" and instead of ">" (shift-<) it shows "X".
> 
> It works correctly if I comment out these lines:
> 
> less 0x2c shift altgr
> greater 0x2d shift altgr

Confirmed, and the fix is verified by independent person with
finnish keyboard -- https://bugzilla.redhat.com/show_bug.cgi?id=794653
Thank you Atro for the help!

The attached patch does just this: removes the two mentioned lines.

index 2a4e0f0..4be7586 100644
--- a/pc-bios/keymaps/fi
+++ b/pc-bios/keymaps/fi
@@ -99,9 +99,7 @@ asterisk 0x2b shift
 acute 0x2b altgr
 multiply 0x2b shift altgr
 guillemotleft 0x2c altgr
-less 0x2c shift altgr
 guillemotright 0x2d altgr
-greater 0x2d shift altgr
 copyright 0x2e altgr
 leftdoublequotemark 0x2f altgr
 grave 0x2f shift altgr


Thanks!

/mjt

Re: [Qemu-devel] Bug#660154: qemu-keymaps: Finnish keyboard mapping broken

[Marko Myllynen]

Hi,

On 2012-03-02 12:55, Michael Tokarev wrote:
> On 17.02.2012 01:58, Timo Sirainen wrote:
>> Subject: qemu-keymaps: Finnish keyboard mapping broken
>> Package: qemu-keymaps
>> Version: 1.0+dfsg-3
>> Severity: normal
>>
>> With "-k fi -vnc :1" the keyboard layout works pretty well, except the key between left shift and "z" key, which generates<>  characters doesn't work. Instead of "<" it shows "z" and instead of">" (shift-<) it shows "X".
>>
>> It works correctly if I comment out these lines:
>>
>> less 0x2c shift altgr
>> greater 0x2d shift altgr
>
> Confirmed, and the fix is verified by independent person with
> finnish keyboard -- https://bugzilla.redhat.com/show_bug.cgi?id=794653
> Thank you Atro for the help!

while the fix above would seem to resolve this specific issue in most 
cases it is probably best to leave the keymap undefined thus avoiding 
using the QEMU internal keymap definitions at all:

https://bugzilla.redhat.com/show_bug.cgi?id=638523
http://hg.fedorahosted.org/hg/python-virtinst/rev/2bde513dcd9e
http://berrange.com/posts/2010/07/04/more-than-you-or-i-ever-wanted-to-know-about-virtual-keyboard-handling/

Cheers,

-- 
Marko Myllynen

[Qemu-devel] [PATCH, repost] qemu-keymaps: Finnish keyboard mapping broken

[Michael Tokarev]

As mentioned in http://bugs.debian.org/660154 , finnish keyboard mapping
is kind of broken.  Fix it as Timo Sirainen suggests in #660154.

index 2a4e0f0..4be7586 100644
--- a/pc-bios/keymaps/fi
+++ b/pc-bios/keymaps/fi
@@ -99,9 +99,7 @@ asterisk 0x2b shift
  acute 0x2b altgr
  multiply 0x2b shift altgr
  guillemotleft 0x2c altgr
-less 0x2c shift altgr
  guillemotright 0x2d altgr
-greater 0x2d shift altgr
  copyright 0x2e altgr
  leftdoublequotemark 0x2f altgr
  grave 0x2f shift altgr


Thanks!

/mjt

[Qemu-devel] [PATCH, repost 2] qemu-keymaps: Finnish keyboard mapping broken

[Michael Tokarev]

As mentioned in http://bugs.debian.org/660154 , finnish keyboard mapping
is kind of broken.  Fix it as Timo Sirainen suggests in #660154.

Signed-off-By: Michael Tokarev <mjt@tls.msk.ru>

index 2a4e0f0..4be7586 100644
--- a/pc-bios/keymaps/fi
+++ b/pc-bios/keymaps/fi
@@ -99,9 +99,7 @@ asterisk 0x2b shift
 acute 0x2b altgr
 multiply 0x2b shift altgr
 guillemotleft 0x2c altgr
-less 0x2c shift altgr
 guillemotright 0x2d altgr
-greater 0x2d shift altgr
 copyright 0x2e altgr
 leftdoublequotemark 0x2f altgr
 grave 0x2f shift altgr


Thanks!

/mjt