From: "Andreas Färber" <afaerber@suse.de>
To: Igor Mitsyanko <i.mitsyanko@samsung.com>
Cc: peter.maydell@linaro.org, e.voevodin@samsung.com,
qemu-devel@nongnu.org, kyungmin.park@samsung.com,
d.solodkiy@samsung.com, m.kozlov@samsung.com
Subject: Re: [Qemu-devel] [PATCH 5/5] hw: add Atmel maxtouch touchscreen implementation
Date: Fri, 02 Mar 2012 15:19:56 +0100 [thread overview]
Message-ID: <4F50D70C.6080908@suse.de> (raw)
In-Reply-To: <1330688145-22944-6-git-send-email-i.mitsyanko@samsung.com>
Hi Igor,
Am 02.03.2012 12:35, schrieb Igor Mitsyanko:
> diff --git a/Makefile.target b/Makefile.target
> index 7968120..05ce652 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -349,6 +349,7 @@ obj-arm-y += exynos4210_gic.o exynos4210_combiner.o exynos4210.o
> obj-arm-y += exynos4_boards.o exynos4210_uart.o exynos4210_pwm.o
> obj-arm-y += exynos4210_pmu.o exynos4210_mct.o exynos4210_fimd.o
> obj-arm-y += exynos4210_i2c.o exynos4210_gpio.o
> +obj-arm-y += maxtouch.o
> obj-arm-y += arm_l2x0.o
> obj-arm-y += arm_mptimer.o a15mpcore.o
> obj-arm-y += armv7m.o armv7m_nvic.o stellaris.o pl022.o stellaris_enet.o
I don't think this touchscreen device is really ARM-specific code-wise,
is it? I would rather expect this to be hw-obj-$(CONFIG_MAXTOUCH) in
Makefile.objs (so that it could be shared with, e.g., AVR).
default-configs/arm-softmmu.mak would need CONFIG_MAXTOUCH=y then.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-03-02 14:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 11:35 [Qemu-devel] [PATCH 0/5] Exynos: i2c, gpio and touchscreen support for NURI board Igor Mitsyanko
2012-03-02 11:35 ` [Qemu-devel] [PATCH 1/5] qom: if @instance_size==0, assign size of object to parent object size Igor Mitsyanko
2012-03-02 11:35 ` [Qemu-devel] [PATCH 2/5] qom/object.c: rename type_class_init() to type_initialize() Igor Mitsyanko
2012-03-06 18:52 ` Peter Maydell
2012-03-02 11:35 ` [Qemu-devel] [PATCH 3/5] exynos4210: add Exynos4210 i2c implementation Igor Mitsyanko
2012-03-06 18:49 ` Peter Maydell
2012-03-07 7:49 ` Igor Mitsyanko
2012-03-02 11:35 ` [Qemu-devel] [PATCH 4/5] exynos4210: add exynos4210 GPIO implementation Igor Mitsyanko
2012-03-02 11:35 ` [Qemu-devel] [PATCH 5/5] hw: add Atmel maxtouch touchscreen implementation Igor Mitsyanko
2012-03-02 14:19 ` Andreas Färber [this message]
2012-03-02 14:43 ` Igor Mitsyanko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F50D70C.6080908@suse.de \
--to=afaerber@suse.de \
--cc=d.solodkiy@samsung.com \
--cc=e.voevodin@samsung.com \
--cc=i.mitsyanko@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=m.kozlov@samsung.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).