From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S3TL0-0000Re-Fv for qemu-devel@nongnu.org; Fri, 02 Mar 2012 09:20:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S3TKx-0002e2-Hq for qemu-devel@nongnu.org; Fri, 02 Mar 2012 09:20:02 -0500 Received: from cantor2.suse.de ([195.135.220.15]:41154 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S3TKx-0002dm-BD for qemu-devel@nongnu.org; Fri, 02 Mar 2012 09:19:59 -0500 Message-ID: <4F50D70C.6080908@suse.de> Date: Fri, 02 Mar 2012 15:19:56 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1330688145-22944-1-git-send-email-i.mitsyanko@samsung.com> <1330688145-22944-6-git-send-email-i.mitsyanko@samsung.com> In-Reply-To: <1330688145-22944-6-git-send-email-i.mitsyanko@samsung.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 5/5] hw: add Atmel maxtouch touchscreen implementation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mitsyanko Cc: peter.maydell@linaro.org, e.voevodin@samsung.com, qemu-devel@nongnu.org, kyungmin.park@samsung.com, d.solodkiy@samsung.com, m.kozlov@samsung.com Hi Igor, Am 02.03.2012 12:35, schrieb Igor Mitsyanko: > diff --git a/Makefile.target b/Makefile.target > index 7968120..05ce652 100644 > --- a/Makefile.target > +++ b/Makefile.target > @@ -349,6 +349,7 @@ obj-arm-y +=3D exynos4210_gic.o exynos4210_combiner= .o exynos4210.o > obj-arm-y +=3D exynos4_boards.o exynos4210_uart.o exynos4210_pwm.o > obj-arm-y +=3D exynos4210_pmu.o exynos4210_mct.o exynos4210_fimd.o > obj-arm-y +=3D exynos4210_i2c.o exynos4210_gpio.o > +obj-arm-y +=3D maxtouch.o > obj-arm-y +=3D arm_l2x0.o > obj-arm-y +=3D arm_mptimer.o a15mpcore.o > obj-arm-y +=3D armv7m.o armv7m_nvic.o stellaris.o pl022.o stellaris_en= et.o I don't think this touchscreen device is really ARM-specific code-wise, is it? I would rather expect this to be hw-obj-$(CONFIG_MAXTOUCH) in Makefile.objs (so that it could be shared with, e.g., AVR). default-configs/arm-softmmu.mak would need CONFIG_MAXTOUCH=3Dy then. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg