From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34754) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S3Ti5-0004Ck-AU for qemu-devel@nongnu.org; Fri, 02 Mar 2012 09:43:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S3Thy-0007zb-Ng for qemu-devel@nongnu.org; Fri, 02 Mar 2012 09:43:52 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:63674) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S3Thy-0007yq-Hy for qemu-devel@nongnu.org; Fri, 02 Mar 2012 09:43:46 -0500 Received: from euspt2 ([210.118.77.14]) by mailout4.w1.samsung.com (Sun Java(tm) System Messaging Server 6.3-8.04 (built Jul 29 2009; 32bit)) with ESMTP id <0M0900A3BI8TNTA0@mailout4.w1.samsung.com> for qemu-devel@nongnu.org; Fri, 02 Mar 2012 14:43:42 +0000 (GMT) Received: from [106.109.8.162] by spt2.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0M090016FI8S74@spt2.w1.samsung.com> for qemu-devel@nongnu.org; Fri, 02 Mar 2012 14:43:41 +0000 (GMT) Date: Fri, 02 Mar 2012 18:43:37 +0400 From: Igor Mitsyanko In-reply-to: <4F50D70C.6080908@suse.de> Message-id: <4F50DC99.8030204@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-15; format=flowed Content-transfer-encoding: QUOTED-PRINTABLE References: <1330688145-22944-1-git-send-email-i.mitsyanko@samsung.com> <1330688145-22944-6-git-send-email-i.mitsyanko@samsung.com> <4F50D70C.6080908@suse.de> Subject: Re: [Qemu-devel] [PATCH 5/5] hw: add Atmel maxtouch touchscreen implementation Reply-To: i.mitsyanko@samsung.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: peter.maydell@linaro.org, e.voevodin@samsung.com, qemu-devel@nongnu.org, kyungmin.park@samsung.com, d.solodkiy@samsung.com, m.kozlov@samsung.com On 03/02/2012 06:19 PM, Andreas F=E4rber wrote: > Hi Igor, > > Am 02.03.2012 12:35, schrieb Igor Mitsyanko: >> diff --git a/Makefile.target b/Makefile.target >> index 7968120..05ce652 100644 >> --- a/Makefile.target >> +++ b/Makefile.target >> @@ -349,6 +349,7 @@ obj-arm-y +=3D exynos4210_gic.o exynos4210_com= biner.o exynos4210.o >> obj-arm-y +=3D exynos4_boards.o exynos4210_uart.o exynos4210_pwm= .o >> obj-arm-y +=3D exynos4210_pmu.o exynos4210_mct.o exynos4210_fimd= .o >> obj-arm-y +=3D exynos4210_i2c.o exynos4210_gpio.o >> +obj-arm-y +=3D maxtouch.o >> obj-arm-y +=3D arm_l2x0.o >> obj-arm-y +=3D arm_mptimer.o a15mpcore.o >> obj-arm-y +=3D armv7m.o armv7m_nvic.o stellaris.o pl022.o stella= ris_enet.o > > I don't think this touchscreen device is really ARM-specific code-w= ise, > is it? I would rather expect this to be hw-obj-$(CONFIG_MAXTOUCH) i= n > Makefile.objs (so that it could be shared with, e.g., AVR). > default-configs/arm-softmmu.mak would need CONFIG_MAXTOUCH=3Dy then= . > > Andreas > Sure, that makes a lot of sense. Originally I was confused by framebuffer.o, bitbang_i2c.o (and a few= =20 other files) in arm-specific obj-arm-y. It gave me an impression that= in=20 case if only one target currently makes use of a certain hardware the= n=20 corresponding hardware sources should be compiled only for this targe= t. --=20 Mitsyanko Igor ASWG, Moscow R&D center, Samsung Electronics email: i.mitsyanko@samsung.com