From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49619)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <brad@comstyle.com>) id 1S3e1U-0000SX-33
	for qemu-devel@nongnu.org; Fri, 02 Mar 2012 20:44:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <brad@comstyle.com>) id 1S3e1A-00034C-0r
	for qemu-devel@nongnu.org; Fri, 02 Mar 2012 20:44:35 -0500
Received: from speedy.comstyle.com ([206.51.28.2]:15080 helo=mail.comstyle.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <brad@comstyle.com>) id 1S3e19-000341-T4
	for qemu-devel@nongnu.org; Fri, 02 Mar 2012 20:44:15 -0500
Message-ID: <4F517769.4020603@comstyle.com>
Date: Fri, 02 Mar 2012 20:44:09 -0500
From: Brad Smith <brad@comstyle.com>
MIME-Version: 1.0
References: <1330703384-17447-1-git-send-email-hdegoede@redhat.com>
In-Reply-To: <1330703384-17447-1-git-send-email-hdegoede@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] libcacard: Fix compilation with gcc-4.7
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Alon Levy <alevy@redhat.com>, qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>

On 02/03/12 10:49 AM, Hans de Goede wrote:
> VCARD_ATR_PREFIX is used as part of an array initializer so it should
> not have () around it, so far this happened to work, but gcc-4.7 does
> not like it.

This recent commit..

libcacard: fix reported ATR length

Broke the build on my OpenBSD (gcc 4.2.1) buildbot which was due to the
change to this macro.

vcard_emul_nss.c:528: warning: left-hand operand of comma expression has 
no effect
vcard_emul_nss.c:528: warning: left-hand operand of comma expression has 
no effect
vcard_emul_nss.c:528: warning: left-hand operand of comma expression has 
no effect
vcard_emul_nss.c:528: warning: left-hand operand of comma expression has 
no effect
vcard_emul_nss.c:528: warning: left-hand operand of comma expression has 
no effect
vcard_emul_nss.c:528: warning: left-hand operand of comma expression has 
no effect
vcard_emul_nss.c:528: warning: left-hand operand of comma expression has 
no effect
vcard_emul_nss.c:528: warning: left-hand operand of comma expression has 
no effect
vcard_emul_nss.c:528: warning: left-hand operand of comma expression has 
no effect
vcard_emul_nss.c:528: error: initializer element is not constant
vcard_emul_nss.c:528: error: (near initialization for 'nss_atr[0]')
gmake[1]: *** [vcard_emul_nss.o] Error 1

> Signed-off-by: Hans de Goede<hdegoede@redhat.com>
> ---
>   libcacard/vcardt.h |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libcacard/vcardt.h b/libcacard/vcardt.h
> index d4d8e2e..d3e9522 100644
> --- a/libcacard/vcardt.h
> +++ b/libcacard/vcardt.h
> @@ -26,8 +26,8 @@ typedef struct VCardEmulStruct VCardEmul;
>   #define MAX_CHANNEL 4
>
>   /* create an ATR with appropriate historical bytes */
> -#define VCARD_ATR_PREFIX(size) (0x3b, 0x68+(size), 0x00, 0xff, \
> -                               'V', 'C', 'A', 'R', 'D', '_')
> +#define VCARD_ATR_PREFIX(size) 0x3b, 0x68+(size), 0x00, 0xff, \
> +                               'V', 'C', 'A', 'R', 'D', '_'
>
>
>   typedef enum {

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.