From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54347) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S3tLi-0008OV-KF for qemu-devel@nongnu.org; Sat, 03 Mar 2012 13:06:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S3tLf-00089e-8S for qemu-devel@nongnu.org; Sat, 03 Mar 2012 13:06:30 -0500 Message-ID: <4F525DA0.6060808@suse.de> Date: Sat, 03 Mar 2012 19:06:24 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <4F524894.7060208@freebsd.org> In-Reply-To: <4F524894.7060208@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] PPC: Add PIR register to POWER7 CPU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nathan Whitehorn Cc: qemu-ppc , QEMU Developers , Alexander Graf Am 03.03.2012 17:36, schrieb Nathan Whitehorn: > The POWER7 emulation is missing the Processor Identification Register, > mandatory in recent POWER CPUs, that is required for SMP on at least > some operating systems (e.g. FreeBSD) to function properly. This patch > copies the existing PIR code from the other CPUs that implement it. >=20 > Signed-off-by: Nathan Whitehorn Please always cc the respective maintainers (and lists) according to MAINTAINERS. CC'ing Alex and qemu-ppc. > --- > target-ppc/translate_init.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) >=20 > diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c > index 8a7233f..01f4030 100644 > --- a/target-ppc/translate_init.c > +++ b/target-ppc/translate_init.c > @@ -6537,6 +6537,11 @@ static void init_proc_POWER7 (CPUPPCState *env) > /* Time base */ > gen_tbl(env); > #if !defined(CONFIG_USER_ONLY) > + /* Processor identification */ > + spr_register(env, SPR_PIR, "PIR", > + SPR_NOACCESS, SPR_NOACCESS, > + &spr_read_generic, &spr_write_pir, Indentation looks weird here. Stray tab maybe? Andreas > + 0x00000000); > /* PURR & SPURR: Hack - treat these as aliases for the TB for now = */ > spr_register(env, SPR_PURR, "PURR", > &spr_read_purr, SPR_NOACCESS, > --=20 > 1.7.9 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg