From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4U8O-0002qX-CN for qemu-devel@nongnu.org; Mon, 05 Mar 2012 04:23:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S4U8K-0005JS-Ud for qemu-devel@nongnu.org; Mon, 05 Mar 2012 04:23:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57580) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4U8K-0005J6-Ln for qemu-devel@nongnu.org; Mon, 05 Mar 2012 04:23:08 -0500 Message-ID: <4F5485F6.9060109@redhat.com> Date: Mon, 05 Mar 2012 11:23:02 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1330893156-26569-1-git-send-email-afaerber@suse.de> <1330893156-26569-2-git-send-email-afaerber@suse.de> In-Reply-To: <1330893156-26569-2-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 1/3] kvmclock: Always register type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: Marcelo Tosatti , qemu-devel@nongnu.org, anthony@codemonkey.ws, lcapitulino@redhat.com On 03/04/2012 10:32 PM, Andreas F=C3=A4rber wrote: > Currently, the "kvmclock" type is only registered when kvm_enabled(). > > This breaks when moving type registration to before command line > parsing (so that QOM types can be used for CPU and machine). > > Since the QOM classes are lazy-initialized anyway and kvmclock_create() > has another kvm_enabled() check, simply drop the KVM check in > kvmclock_register_types(). > > kvm-i8259, kvm-apic and kvm-ioapic do not suffer from such a check. Patch looks good. --=20 error compiling committee.c: too many arguments to function