From: Kevin Wolf <kwolf@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: stefanha@linux.vnet.ibm.com, jcody@redhat.com,
qemu-devel@nongnu.org, lcapitulino@redhat.com,
fsimonce@redhat.com, Anthony Liguori <anthony@codemonkey.ws>,
eblake@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 0/6] Mirrored writes using blockdev-transaction
Date: Mon, 05 Mar 2012 13:13:14 +0100 [thread overview]
Message-ID: <4F54ADDA.2090505@redhat.com> (raw)
In-Reply-To: <4F54874E.1030509@redhat.com>
Am 05.03.2012 10:28, schrieb Paolo Bonzini:
> Il 05/03/2012 09:53, Kevin Wolf ha scritto:
>>>>
>>>> I think we need some sort of introspection method too in order for clients to
>>>> figure out when the command is extended.
>> How about coupling the types with independently available commands for
>> now? We would rename 'snapshot' to 'blockdev-snapshot-sync', which does
>> the same thing outside of transactions. The mirror patches would then
>> introduce a 'drive-mirror' top-level command at the same time as they
>> introduce a 'drive-mirror' transaction type.
>
> Makes sense. It would also be a good excuse to port
> blockdev-snapshot-sync to the new fail-safe way. I'll refresh my
> patches if there's consensus.
Will you also replace 'blockdev-transaction' by 'transaction' to keep
things generic at the interface level? The necessary refactoring to
actually make it useful outside the block layer can come later, but we
can leave the external API stable then.
Kevin
next prev parent reply other threads:[~2012-03-05 12:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 11:21 [Qemu-devel] [PATCH v2 0/6] Mirrored writes using blockdev-transaction Paolo Bonzini
2012-03-01 11:21 ` [Qemu-devel] [PATCH v2 1/6] fix format name for backing file Paolo Bonzini
2012-03-01 11:21 ` [Qemu-devel] [PATCH v2 2/6] qapi: complete implementation of unions Paolo Bonzini
2012-03-01 13:52 ` Kevin Wolf
2012-03-01 15:56 ` Luiz Capitulino
2012-03-01 11:21 ` [Qemu-devel] [PATCH v2 3/6] rename blockdev-group-snapshot-sync Paolo Bonzini
2012-03-01 11:21 ` [Qemu-devel] [PATCH v2 4/6] add reuse field Paolo Bonzini
2012-03-01 11:21 ` [Qemu-devel] [PATCH v2 5/6] Add blkmirror block driver Paolo Bonzini
2012-03-01 11:21 ` [Qemu-devel] [PATCH v2 6/6] add mirroring to blockdev-transaction Paolo Bonzini
2012-03-01 16:02 ` [Qemu-devel] [PATCH v2 0/6] Mirrored writes using blockdev-transaction Luiz Capitulino
2012-03-01 16:18 ` Kevin Wolf
2012-03-01 16:43 ` Luiz Capitulino
2012-03-01 21:10 ` Anthony Liguori
2012-03-01 21:30 ` Eric Blake
2012-03-01 21:36 ` Anthony Liguori
2012-03-02 13:05 ` Anthony Liguori
2012-03-05 8:53 ` Kevin Wolf
2012-03-05 9:28 ` Paolo Bonzini
2012-03-05 12:13 ` Kevin Wolf [this message]
2012-03-05 13:05 ` Paolo Bonzini
2012-03-05 14:47 ` Anthony Liguori
2012-03-05 14:54 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F54ADDA.2090505@redhat.com \
--to=kwolf@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=eblake@redhat.com \
--cc=fsimonce@redhat.com \
--cc=jcody@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).