From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38515) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4Wjm-0003HN-Bl for qemu-devel@nongnu.org; Mon, 05 Mar 2012 07:10:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S4Wjc-0007my-Hh for qemu-devel@nongnu.org; Mon, 05 Mar 2012 07:09:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:13826) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4Wjc-0007mp-90 for qemu-devel@nongnu.org; Mon, 05 Mar 2012 07:09:48 -0500 Message-ID: <4F54ADDA.2090505@redhat.com> Date: Mon, 05 Mar 2012 13:13:14 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1330600908-16202-1-git-send-email-pbonzini@redhat.com> <4F4FE5B7.2080306@codemonkey.ws> <4F547EFA.3020606@redhat.com> <4F54874E.1030509@redhat.com> In-Reply-To: <4F54874E.1030509@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/6] Mirrored writes using blockdev-transaction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: stefanha@linux.vnet.ibm.com, jcody@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, fsimonce@redhat.com, Anthony Liguori , eblake@redhat.com Am 05.03.2012 10:28, schrieb Paolo Bonzini: > Il 05/03/2012 09:53, Kevin Wolf ha scritto: >>>> >>>> I think we need some sort of introspection method too in order for clients to >>>> figure out when the command is extended. >> How about coupling the types with independently available commands for >> now? We would rename 'snapshot' to 'blockdev-snapshot-sync', which does >> the same thing outside of transactions. The mirror patches would then >> introduce a 'drive-mirror' top-level command at the same time as they >> introduce a 'drive-mirror' transaction type. > > Makes sense. It would also be a good excuse to port > blockdev-snapshot-sync to the new fail-safe way. I'll refresh my > patches if there's consensus. Will you also replace 'blockdev-transaction' by 'transaction' to keep things generic at the interface level? The necessary refactoring to actually make it useful outside the block layer can come later, but we can leave the external API stable then. Kevin