From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49954) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4Xso-0007r2-3i for qemu-devel@nongnu.org; Mon, 05 Mar 2012 08:23:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S4Xsh-0000h6-LQ for qemu-devel@nongnu.org; Mon, 05 Mar 2012 08:23:21 -0500 Message-ID: <4F54BE41.7040409@suse.de> Date: Mon, 05 Mar 2012 14:23:13 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1330928551-6452-1-git-send-email-sw@weilnetz.de> In-Reply-To: <1330928551-6452-1-git-send-email-sw@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] osdep: Remove local definition of macro offsetof List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-trivial , qemu-devel@nongnu.org Am 05.03.2012 07:22, schrieb Stefan Weil: > The macro offsetof is defined in stddef.h. It is conforming to > the standards C89, C99 and POSIX.1-2001 (see man page), so it > is a sufficiently old standard. >=20 > Therefore chances are very high that QEMU never needs a local > definition of this macro. >=20 > osdep.h already includes stddef.h, so this patch simply removes > the unneeded code from the files configure and osdep.h. >=20 > If we ever need the local definition again, it should be added > to compiler.h (the macro is usually provided with the compiler, > it is not OS specific). >=20 > Signed-off-by: Stefan Weil Did you check when this was introduced and whether the commit message gave any explanation why? Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg