From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57061)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1S4Yfl-0000Bt-5q
	for qemu-devel@nongnu.org; Mon, 05 Mar 2012 09:14:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1S4YfM-0002Oy-IO
	for qemu-devel@nongnu.org; Mon, 05 Mar 2012 09:13:56 -0500
Received: from mx1.redhat.com ([209.132.183.28]:17281)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1S4YfM-0002OY-A7
	for qemu-devel@nongnu.org; Mon, 05 Mar 2012 09:13:32 -0500
Message-ID: <4F54CA04.4070804@redhat.com>
Date: Mon, 05 Mar 2012 16:13:24 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <87ehuhrpel.fsf@elfo.elfo> <4F272A92.2010609@suse.de>
	<4F272D8C.8020608@codemonkey.ws> <4F27E98E.2080501@suse.de>
	<CAFEAcA_u2qTgnaNMvVRn_K+3SrbaTLMUs4NH654wgQGAnFGxTg@mail.gmail.com>
	<CAFEAcA86m4wKbDFQk=Qmn3mUDDuPod9q15HgGBgPk0sFkC2sag@mail.gmail.com>
	<4F54C1C0.6030803@samsung.com>
In-Reply-To: <4F54C1C0.6030803@samsung.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] KVM call agenda for tuesday 31
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: i.mitsyanko@samsung.com
Cc: Peter Maydell <peter.maydell@linaro.org>, KVM devel mailing list <kvm@vger.kernel.org>, quintela@redhat.com, Developers qemu-devel <qemu-devel@nongnu.org>, Dmitry Solodkiy <d.solodkiy@samsung.com>, Anthony Liguori <anthony@codemonkey.ws>, =?UTF-8?B?QW5kcmVhcyBGw6RyYg==?= =?UTF-8?B?ZXI=?= <afaerber@suse.de>

On 03/05/2012 03:38 PM, Igor Mitsyanko wrote:
>> Short summary:
>>   * switch wp groups to bitfield rather than int array
>>   * convert sd.c to use memory_region_init_ram() to allocate the wp
>> groups
>> (being careful to use memory_region_set_dirty() when we touch them)
>>   * we don't need variable-length fields for sd.c any more
>>   * rest of the vmstate conversion is straightforward
>>
>
> OK, it turned out to be not so simple, we can't use memory API in sd.c
> because TARGET_PHYS_ADDR_BITS value (and, consequently,
> target_phys_addr_t) is not defined for common objects.
>

Well, can't you make sd.c target dependent?  It's not so nice, but it
does solve the problem.

-- 
error compiling committee.c: too many arguments to function