From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33491) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4ZJO-0007qt-Qg for qemu-devel@nongnu.org; Mon, 05 Mar 2012 09:55:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S4ZJI-0004KY-I2 for qemu-devel@nongnu.org; Mon, 05 Mar 2012 09:54:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50824) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4ZJI-0004KD-95 for qemu-devel@nongnu.org; Mon, 05 Mar 2012 09:54:48 -0500 Message-ID: <4F54D398.5020703@redhat.com> Date: Mon, 05 Mar 2012 15:54:16 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1330600908-16202-1-git-send-email-pbonzini@redhat.com> <4F4FE5B7.2080306@codemonkey.ws> <4F547EFA.3020606@redhat.com> <4F54D1EA.4060006@codemonkey.ws> In-Reply-To: <4F54D1EA.4060006@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/6] Mirrored writes using blockdev-transaction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Kevin Wolf , stefanha@linux.vnet.ibm.com, jcody@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, fsimonce@redhat.com, eblake@redhat.com Il 05/03/2012 15:47, Anthony Liguori ha scritto: >> How about coupling the types with independently available commands for >> now? We would rename 'snapshot' to 'blockdev-snapshot-sync', which does >> the same thing outside of transactions. The mirror patches would then >> introduce a 'drive-mirror' top-level command at the same time as they >> introduce a 'drive-mirror' transaction type. > > I think it's reasonable but we need to make sure to document the > relationship here explicitly in the schema. We can easily add a query-commands-transaction that returns the commands that can be placed in a transaction. Paolo