From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41983) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4bMy-0002n4-Ir for qemu-devel@nongnu.org; Mon, 05 Mar 2012 12:07:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S4bMY-0003Gl-G0 for qemu-devel@nongnu.org; Mon, 05 Mar 2012 12:06:44 -0500 Received: from relay1.mentorg.com ([192.94.38.131]:42010) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4bMY-0003FD-AB for qemu-devel@nongnu.org; Mon, 05 Mar 2012 12:06:18 -0500 Message-ID: <4F54F283.6020207@codesourcery.com> Date: Mon, 5 Mar 2012 11:06:11 -0600 From: Meador Inge MIME-Version: 1.0 References: <1330004654-428-1-git-send-email-meadori@codesourcery.com> In-Reply-To: <1330004654-428-1-git-send-email-meadori@codesourcery.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 1/1] ppc: Correctly define POWERPC_INSNS2_DEFAULT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: agraf@suse.de On 02/23/2012 07:44 AM, Meador Inge wrote: > 'POWERPC_INSNS2_DEFAULT' was defined incorrectly which was causing the > opcode table creation code to erroneously register 'eieio' and 'mbar' > for the "default" processor: > > ** ERROR: opcode 1a already assigned in opcode table 16 > *** ERROR: unable to insert opcode [1f-16-1a] > *** ERROR initializing PowerPC instruction 0x1f 0x16 0x1a > > Signed-off-by: Meador Inge Ping. > --- > target-ppc/translate_init.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c > index 6253076..6cb5fad 100644 > --- a/target-ppc/translate_init.c > +++ b/target-ppc/translate_init.c > @@ -6713,7 +6713,7 @@ static void init_proc_620 (CPUPPCState *env) > #if defined (TARGET_PPC64) && 0 // XXX: TODO > #define CPU_POWERPC_DEFAULT CPU_POWERPC_PPC64 > #define POWERPC_INSNS_DEFAULT POWERPC_INSNS_PPC64 > -#define POWERPC_INSNS2_DEFAULT POWERPC_INSNS_PPC64 > +#define POWERPC_INSNS2_DEFAULT POWERPC_INSNS2_PPC64 > #define POWERPC_MSRM_DEFAULT POWERPC_MSRM_PPC64 > #define POWERPC_MMU_DEFAULT POWERPC_MMU_PPC64 > #define POWERPC_EXCP_DEFAULT POWERPC_EXCP_PPC64 > @@ -6725,7 +6725,7 @@ static void init_proc_620 (CPUPPCState *env) > #else > #define CPU_POWERPC_DEFAULT CPU_POWERPC_PPC32 > #define POWERPC_INSNS_DEFAULT POWERPC_INSNS_PPC32 > -#define POWERPC_INSNS2_DEFAULT POWERPC_INSNS_PPC32 > +#define POWERPC_INSNS2_DEFAULT POWERPC_INSNS2_PPC32 > #define POWERPC_MSRM_DEFAULT POWERPC_MSRM_PPC32 > #define POWERPC_MMU_DEFAULT POWERPC_MMU_PPC32 > #define POWERPC_EXCP_DEFAULT POWERPC_EXCP_PPC32 -- Meador Inge CodeSourcery / Mentor Embedded http://www.mentor.com/embedded-software