From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59095) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4baq-00071d-1k for qemu-devel@nongnu.org; Mon, 05 Mar 2012 12:21:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S4bao-0007Lf-9p for qemu-devel@nongnu.org; Mon, 05 Mar 2012 12:21:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35175) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4bao-0007LO-1l for qemu-devel@nongnu.org; Mon, 05 Mar 2012 12:21:02 -0500 Message-ID: <4F54F5F8.70105@redhat.com> Date: Mon, 05 Mar 2012 19:20:56 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1330956981-5001-1-git-send-email-alevy@redhat.com> <4F54CEA2.10808@codemonkey.ws> In-Reply-To: <4F54CEA2.10808@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: lcapitulino@redhat.com, Alon Levy , kraxel@redhat.com, qemu-devel@nongnu.org On 03/05/2012 04:33 PM, Anthony Liguori wrote: > > > async in QEMU doesn't mean "generate a QMP event when you're done". > It should mean execute this closure when you finish (function pointer > + opaque). > > The QMP event should be dispatched from the closure such that the > screendump code doesn't have to have a direct dependency on QMP. > What about using the parallel execution facility of qmp? It's silly to duplicate every command X with X-async and X-COMPLETED. -- error compiling committee.c: too many arguments to function